Uh oh!
There was an error while loading. Please reload this page.
gh-71052: Add test exclusions to support running the test suite on Android - #115918
Merged
Conversation
mhsmith
requested review from
1st1, asvetlov, barneygale, ericsnowcurrently, gvanrossum, kumaraditya303, vsajip and willingc
as code ownersFebruary 25, 2024 16:49
mhsmithforce-pushed
the
android-test-skips
branch
from
February 25, 2024 17:04
c5bec30 to
f2e8385CompareEclips4
reviewed
Feb 25, 2024
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Comment on lines
-2495
to
+2501
| os.chdir(os.sep) | ||
| self.assertEqual(set(os.listdir()), set(os.listdir(os.sep))) | ||
| # The root directory is not readable on Android, so use a directory | ||
| # we created ourselves. | ||
| os.chdir(self.dir) | ||
| self.assertEqual(set(os.listdir()), expected) |
mhsmith
commented
Feb 29, 2024
MemberAuthor
@erlend-aasland: You reviewed the equivalent PR for iOS (#114889); would you like to take a look at this one for Android? It's much smaller. |
erlend-aasland
approved these changes
Feb 29, 2024
erlend-aasland
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me; thanks!
woodruffw pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
adorilson pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #114889 by @freakboy3742. It marks Android as not supporting subprocesses, and skips some additional tests which can't be run on this platform.
Some multiprocessing-related test changes have been submitted separately in #115917.