Uh oh!
There was an error while loading. Please reload this page.
gh-112075: Enable freeing with qsbr and fallback to lock on key changed - #116336
Merged
Conversation
bedevere-bot
commented
Mar 4, 2024
🤖 New build scheduled with the buildbot fleet by @colesbury for commit df67d40 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
colesbury
approved these changes
Mar 4, 2024
colesbury
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but I suggest waiting for the refleak buildbots because it tends to be sensitive to the QSBR stuff
DinoV
marked this pull request as ready for review
March 4, 2024 22:42
adorilson pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couple of small tweaks for dict thread safety:
DKIX_KEY_CHANGEDwhen storing instance attributes. This was introduced with gh-112075: Avoid locking shared keys on every assignment #116087 and got exposed when combining it with GH-115776: Embed the values array into the object, for "normal" Python objects. #116115dictobjects thread-safe in--disable-gilbuilds #112075