Skip to content

gh-116386: Fix format string "%ld" warning in _xxinterpqueuesmodule - #116387

Merged
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-116386
Mar 7, 2024
Merged

gh-116386: Fix format string "%ld" warning in _xxinterpqueuesmodule#116387
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-116386

Conversation

@sobolevn

@sobolevnsobolevn commented Mar 5, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Mar 5, 2024
Closed
@AlexWaygoodAlexWaygood mentioned this pull request Mar 5, 2024
Merged
gvanrossum
gvanrossum approved these changes Mar 5, 2024
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No warnings on macOS.

serhiy-storchaka
serhiy-storchaka reviewed Mar 6, 2024
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not be more natural to use the %zd format string?

And this looks like a completely different issue than the originally reported one.

@ericsnowcurrently

ericsnowcurrently commented Mar 6, 2024

Copy link
Copy Markdown
Member

Would not be more natural to use the %zd format string?

Yeah, that was a copy-paste failure on my part. I shouldn't have used PRId64 for _queue.count since it is Py_ssize_t, not int64_t. Using %zd sounds right.

And this looks like a completely different issue than the originally reported one.

This is a fix for my fix (gh-116369) for that originally reported issue.

ericsnowcurrently
ericsnowcurrently requested changes Mar 6, 2024
View reviewed changes
Comment threadModules/_xxinterpqueuesmodule.c Outdated
@bedevere-app

bedevere-appBot commented Mar 6, 2024

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

ericsnowcurrently
ericsnowcurrently approved these changes Mar 6, 2024
View reviewed changes

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn
sobolevn merged commit 40b79ef into python:mainMar 7, 2024
@sobolevn

sobolevn commented Mar 7, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks for the help and reviews!

@ericsnowcurrently

ericsnowcurrently commented Mar 7, 2024

Copy link
Copy Markdown
Member

Thanks for fixing this. 😄

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@sobolevn@adorilson
pythongh-116386: Fix format string "%ld" warning in `_xxinterpqueuesm…
014060f
…odule` (python#116387)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sobolevn@diegorusso
pythongh-116386: Fix format string "%ld" warning in `_xxinterpqueuesm…
e81040f
…odule` (python#116387)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments
@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes
@gvanrossumgvanrossumgvanrossum approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@ericsnowcurrently@gvanrossum@serhiy-storchaka