gh-112087: Store memory allocation information into _PyListArray by corona10 · Pull Request #116529 · python/cpython

corona10 · 2024-03-09T02:11:35Z

Issue: Make list objects thread-safe in --disable-gil builds #112087

corona10 · 2024-03-09T02:14:22Z

+ PyObject **old_items = self->ob_item;
+ if (self->ob_item) {
+ if (allocated < new_allocated) {
+ memcpy(&array->ob_item, self->ob_item, allocated * sizeof(PyObject*));


Thank you for catching shrink case, @colesbury

bedevere-bot · 2024-03-09T02:14:33Z

🤖 New build scheduled with the buildbot fleet by @corona10 for commit b98f853 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot · 2024-03-09T02:16:08Z

🤖 New build scheduled with the buildbot fleet by @corona10 for commit d1ac2d4 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot · 2024-03-09T02:16:22Z

🤖 New build scheduled with the buildbot fleet by @corona10 for commit d1ac2d4 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

corona10 · 2024-03-09T02:17:54Z

@@ -0,0 +1 @@
+:class:`list` is now compatible with the implementation of :pep:`703`.


This PR should be the final PR for #112087.
I think that we can close the issue, and after GIL is disabled, we can track relevant issues from a separate issue.

One more thing I noticed here is that list.sort should have a critical section

corona10 · 2024-03-09T02:37:17Z

PPC related failure: Not related to this PR.

/tmp/ccfdq0MP.s: Fatal error: can't write 821 bytes to section .gnu.lto_ucs4lib_rfind.672.76bf242dbd85e46 of Objects/unicodeobject.o: 'No space left on device'
/tmp/ccfdq0MP.s: Fatal error: Objects/unicodeobject.o: No such file or directory
make: *** [Makefile:3000: Objects/unicodeobject.o] Error 1

bedevere-bot · 2024-03-09T03:52:21Z

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 3b7d24e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot · 2024-03-09T09:32:06Z

🤖 New build scheduled with the buildbot fleet by @corona10 for commit eb277c4 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

colesbury · 2024-03-09T21:27:07Z

+#ifdef Py_GIL_DISABLED
+typedef struct {
+ Py_ssize_t allocated;
+ PyObject *ob_item;


This needs to be a flexible array member like:
Suggested change
PyObject*ob_item;
PyObject*ob_item[];
Like dk_indices in PyDictKeysObject
cpython/Include/internal/pycore_dict.h
Line 167 in 1e68c4b
chardk_indices[]; /* char is required to avoid strict aliasing. */

colesbury · 2024-03-09T21:37:43Z

@@ -0,0 +1 @@
+:class:`list` is now compatible with the implementation of :pep:`703`.


One more thing I noticed here is that list.sort should have a critical section

corona10 · 2024-03-09T23:34:12Z

One more thing I noticed here is that list.sort should have a critical section

I will submit the PR right a way.

pythongh-116529)

pythongh-112087: Store memory allocation information into _PyListArray
b98f853

corona10 added the topic-free-threading label Mar 9, 2024

corona10 requested a review from colesbury March 9, 2024 02:11

bedevere-appBot added the awaiting core review label Mar 9, 2024

bedevere-appBot mentioned this pull request Mar 9, 2024
Make list objects thread-safe in --disable-gil builds #112087
Closed
4 tasks

corona10 commented Mar 9, 2024
View reviewed changes

Comment threadObjects/listobject.c

corona10 commented Mar 9, 2024
View reviewed changes

corona10 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2024

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2024

corona10 linked an issue Mar 9, 2024 that may be closed by this pull request
Make list objects thread-safe in --disable-gil builds #112087
Closed
4 tasks

nit
d1ac2d4

corona10 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2024

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2024

corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 9, 2024

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 9, 2024

corona10 commented Mar 9, 2024
View reviewed changes

Fix casting
3b7d24e

corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 9, 2024

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 9, 2024

corona10 added 3 commits March 9, 2024 17:48

nit
460dbc4

nit
d429298

fix
eb277c4

corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 9, 2024

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 9, 2024

corona10 commented Mar 9, 2024
View reviewed changes

Comment threadObjects/listobject.c Outdated

colesbury reviewed Mar 9, 2024
View reviewed changes

corona10 added 2 commits March 10, 2024 05:35

Address code review
2252858

Address code review
2493543

corona10 requested a review from colesbury March 9, 2024 20:42

colesbury reviewed Mar 9, 2024
View reviewed changes

Address code review
a60d9cb

colesbury approved these changes Mar 9, 2024
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting core review labels Mar 9, 2024

corona10 removed a link to an issue Mar 9, 2024
Make list objects thread-safe in --disable-gil builds #112087
Closed
4 tasks

corona10 enabled auto-merge (squash) March 9, 2024 23:33

corona10 merged commit 17d31bf into python:mainMar 9, 2024

bedevere-appBot removed the awaiting merge label Mar 9, 2024

corona10 deleted the gh-112087-allocation branch March 9, 2024 23:53

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
pythongh-112087: Store memory allocation information into _PyListArray (
7f096bc
pythongh-116529)

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
pythongh-112087: Store memory allocation information into _PyListArray (
6429975
pythongh-116529)

		@@ -0,0 +1 @@
		:class:`list` is now compatible with the implementation of :pep:`703`.

Uh oh!

Uh oh!

Conversation

corona10 commented Mar 9, 2024• edited by bedevere-app BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

corona10Mar 9, 2024

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Mar 9, 2024

Uh oh!

bedevere-bot commented Mar 9, 2024

Uh oh!

bedevere-bot commented Mar 9, 2024

Uh oh!

corona10Mar 9, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

colesburyMar 9, 2024

Choose a reason for hiding this comment

Uh oh!

corona10 commented Mar 9, 2024

Uh oh!

bedevere-bot commented Mar 9, 2024

Uh oh!

bedevere-bot commented Mar 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

colesburyMar 9, 2024

Choose a reason for hiding this comment

Uh oh!

colesburyMar 9, 2024

Choose a reason for hiding this comment

Uh oh!

corona10 commented Mar 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

corona10 commented Mar 9, 2024•
edited by bedevere-app Bot
Loading

corona10Mar 9, 2024•
edited
Loading