Skip to content

gh-90190: Add doc for using singledispatch with precise collection type hints - #116544

Merged
AlexWaygood merged 8 commits into
python:mainfrom
Delengowski:add-docs-singledispatch-generic-alias-90190
Sep 27, 2024
Merged

gh-90190: Add doc for using singledispatch with precise collection type hints#116544
AlexWaygood merged 8 commits into
python:mainfrom
Delengowski:add-docs-singledispatch-generic-alias-90190

Conversation

@Delengowski

@DelengowskiDelengowski commented Mar 9, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

@ghost

ghost commented Mar 9, 2024•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-appbedevere-appBot added awaiting review docs Documentation in the Doc dir skip news labels Mar 9, 2024
@bedevere-appbedevere-appBot mentioned this pull request Mar 9, 2024
Closed
@AlexWaygood
AlexWaygood self-requested a review March 9, 2024 14:37
@rhettinger
rhettinger removed their request for review March 9, 2024 18:25
savannahostrowski
savannahostrowski reviewed May 9, 2024
View reviewed changes
Comment threadDoc/library/functools.rst Outdated
savannahostrowski
savannahostrowski reviewed May 9, 2024
View reviewed changes
Comment threadDoc/library/functools.rst Outdated
savannahostrowski
savannahostrowski reviewed May 9, 2024
View reviewed changes
Comment threadDoc/library/functools.rst Outdated
savannahostrowski
savannahostrowski previously requested changes May 9, 2024
View reviewed changes

@savannahostrowskisavannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think that this looks good. I had a couple of small comments/nits.

@Delengowski

Delengowski commented May 26, 2024

Copy link
Copy Markdown
ContributorAuthor

@savannahostrowski thank you for the review. I believe I resolved all comments.

@AlexWaygood Would you be able to look at this when you get a chance? You originally told me to add you when I mentioned a desire to do this in the linked issue.

@AlexWaygood

AlexWaygood commented May 26, 2024

Copy link
Copy Markdown
Member

Sorry, this dropped off my radar; will try to take a look soon!

@AlexWaygoodAlexWaygood added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 27, 2024
@savannahostrowski

savannahostrowski commented Sep 27, 2024

Copy link
Copy Markdown
Member

@AlexWaygood I was going through PRs and noticed that this may have slipped through the cracks. Thoughts?

AlexWaygood
AlexWaygood approved these changes Sep 27, 2024
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and thanks @savannahostrowski for the ping! Sorry for the delay here, this is great

@AlexWaygoodAlexWaygood changed the title gh-90190: Adds doc for singledispatch with GenericAlias annotationgh-90190: Add doc for using singledispatch with precise collection type hintsSep 27, 2024
@AlexWaygood
AlexWaygood enabled auto-merge (squash) September 27, 2024 20:51
@AlexWaygood
AlexWaygood merged commit 2357d5b into python:mainSep 27, 2024
@miss-islington-app

miss-islington-appBot commented Sep 27, 2024

Copy link
Copy Markdown

Thanks @Delengowski for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@Delengowski@miss-islington
pythongh-90190: Add doc for usingsingledispatchwith precise colle…
0864743
…ction type hints (pythonGH-116544)
(cherry picked from commit 2357d5b)
Co-authored-by: Matt Delengowski <matt.delengowski@gmail.com>
@bedevere-app

bedevere-appBot commented Sep 27, 2024

Copy link
Copy Markdown

GH-124710 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@Delengowski@miss-islington
pythongh-90190: Add doc for usingsingledispatchwith precise colle…
ea2ca32
…ction type hints (pythonGH-116544)
(cherry picked from commit 2357d5b)
Co-authored-by: Matt Delengowski <matt.delengowski@gmail.com>
@bedevere-app

bedevere-appBot commented Sep 27, 2024

Copy link
Copy Markdown

GH-124711 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Sep 27, 2024
AlexWaygood pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington@Delengowski
[3.12]gh-90190: Add doc for usingsingledispatchwith precise coll…
a178445
…ection type hints (GH-116544) (#124711)
Co-authored-by: Matt Delengowski <matt.delengowski@gmail.com>
Yhg1s pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington@Delengowski
[3.13]gh-90190: Add doc for usingsingledispatchwith precise coll…
2b74cce
…ection type hints (GH-116544) (#124710)
gh-90190: Add doc for using `singledispatch` with precise collection type hints (GH-116544)
(cherry picked from commit 2357d5b)
Co-authored-by: Matt Delengowski <matt.delengowski@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes
@savannahostrowskisavannahostrowskisavannahostrowski left review comments

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Delengowski@AlexWaygood@savannahostrowski