Skip to content

gh-116576: Fix Tools/scripts/sortperf.py sorting the same list - #116577

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-116576
Mar 11, 2024
Merged

gh-116576: Fix Tools/scripts/sortperf.py sorting the same list#116577
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-116576

Conversation

@sobolevn

@sobolevnsobolevn commented Mar 10, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Before:

» python Tools/scripts/sortperf.py
.....................
list_sort: Mean +- std dev: 29.7 us +- 0.1 us
.....................
list_sort_ascending: Mean +- std dev: 29.3 us +- 0.1 us
.....................
list_sort_ascending_exchanged: Mean +- std dev: 29.3 us +- 0.0 us
.....................
list_sort_ascending_one_percent: Mean +- std dev: 29.3 us +- 0.0 us
.....................
list_sort_ascending_random: Mean +- std dev: 29.3 us +- 0.1 us
.....................
list_sort_descending: Mean +- std dev: 29.3 us +- 0.1 us
.....................
list_sort_duplicates: Mean +- std dev: 30.3 us +- 1.1 us
.....................
list_sort_equal: Mean +- std dev: 29.0 us +- 0.1 us
.....................
list_sort_worst_case: Mean +- std dev: 29.1 us +- 0.1 us

After:

» python Tools/scripts/sortperf.py .....................
list_sort: Mean +- std dev: 1.33 ms +- 0.01 ms
.....................
list_sort_ascending: Mean +- std dev: 30.5 us +- 1.0 us
.....................
list_sort_ascending_exchanged: Mean +- std dev: 35.3 us +- 1.9 us
.....................
list_sort_ascending_one_percent: Mean +- std dev: 86.8 us +- 3.1 us
.....................
list_sort_ascending_random: Mean +- std dev: 34.8 us +- 1.1 us
.....................
list_sort_descending: Mean +- std dev: 33.4 us +- 0.6 us
.....................
list_sort_duplicates: Mean +- std dev: 456 us +- 8 us
.....................
list_sort_equal: Mean +- std dev: 29.8 us +- 0.6 us
.....................
list_sort_worst_case: Mean +- std dev: 59.7 us +- 1.2 us

Refs #114687

@sobolevn
sobolevn requested a review from corona10March 10, 2024 22:47
@bedevere-appbedevere-appBot mentioned this pull request Mar 10, 2024
Closed
corona10
corona10 approved these changes Mar 10, 2024
View reviewed changes

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn
sobolevn merged commit 4704e55 into python:mainMar 11, 2024
@miss-islington-app

miss-islington-appBot commented Mar 11, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2024
@sobolevn@miss-islington
pythongh-116576: FixTools/scripts/sortperf.pysorting the same list (
ad11814
pythonGH-116577)
(cherry picked from commit 4704e55)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app

bedevere-appBot commented Mar 11, 2024

Copy link
Copy Markdown

GH-116582 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2024
@sobolevn@miss-islington
pythongh-116576: FixTools/scripts/sortperf.pysorting the same list (
cad4234
pythonGH-116577)
(cherry picked from commit 4704e55)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Mar 11, 2024
@bedevere-app

bedevere-appBot commented Mar 11, 2024

Copy link
Copy Markdown

GH-116583 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Mar 11, 2024
sobolevn added a commit that referenced this pull request Mar 11, 2024
@miss-islington@sobolevn
[3.12]gh-116576: FixTools/scripts/sortperf.pysorting the same li…
de239be
…st (GH-116577) (#116582)
gh-116576: Fix `Tools/scripts/sortperf.py` sorting the same list (GH-116577)
(cherry picked from commit 4704e55)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Mar 11, 2024
@miss-islington@sobolevn
[3.11]gh-116576: FixTools/scripts/sortperf.pysorting the same li…
34e808e
…st (GH-116577) (#116583)
gh-116576: Fix `Tools/scripts/sortperf.py` sorting the same list (GH-116577)
(cherry picked from commit 4704e55)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@sobolevn@adorilson
pythongh-116576: FixTools/scripts/sortperf.pysorting the same list (
d2074e2
python#116577)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sobolevn@diegorusso
pythongh-116576: FixTools/scripts/sortperf.pysorting the same list (
fafb430
python#116577)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10corona10 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn@corona10