Uh oh!
There was an error while loading. Please reload this page.
gh-116616: Use relaxed atomic ops to access socket module defaulttimeout - #116623
Merged
Conversation
erlend-aasland
commented
Mar 11, 2024
ContributorAuthor
@colesbury, there's also a store in the module exec function. Let me if we need to use atomic access these as well. |
colesbury
commented
Mar 11, 2024
Contributor
I don't think we need atomics for the initialization in the module exec function. The module state is not visible to other threads at that point, and the internal import locks provide the necessary synchronization. |
colesbury
approved these changes
Mar 12, 2024
erlend-aasland
commented
Mar 12, 2024
ContributorAuthor
Thanks for the patch and the review, @colesbury 😅 |
adorilson pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…lttimeout (python#116623) Co-authored-by: Sam Gross <colesbury@gmail.com>
diegorusso pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…lttimeout (python#116623) Co-authored-by: Sam Gross <colesbury@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaulttimeoutin free-threaded build #116616