Uh oh!
There was an error while loading. Please reload this page.
gh-113317: Add libclinic.block_parser and libclinic.language modules - #116819
Conversation
* Move Block and BlockParser classes to a new libclinic.block_parser module. * Move Language and PythonLanguage classes to a new libclinic.language module.
erlend-aasland
commented
Mar 19, 2024
Would it not be better to create a |
Instead of
Now, we suddenly have C language stuff scattered over two submodules: |
erlend-aasland
commented
Mar 19, 2024
Should |
vstinner
commented
Mar 19, 2024
I started with very small files to break inter-dependencies, otherwise it's not possible to move any line of code. Once more more will live in libclinic, it will be easier to move related code together. CLanguage should live in its on own file, right. |
vstinner
commented
Mar 19, 2024
BlockParser creates Block, so they are related, no?
I didn't manage to move it yet. But I would prefer to separate parsing code and code genereration code in different files, if possible. |
erlend-aasland
commented
Mar 19, 2024
Yes, this is something we've been discussing. How about putting the intermediate representation ( |
* Move Block and BlockParser classes to a new libclinic.block_parser module. * Move Language and PythonLanguage classes to a new libclinic.language module.
* Move Block and BlockParser classes to a new libclinic.block_parser module. * Move Language and PythonLanguage classes to a new libclinic.language module.
* Move Block and BlockParser classes to a new libclinic.block_parser module. * Move Language and PythonLanguage classes to a new libclinic.language module.
Uh oh!
There was an error while loading. Please reload this page.