Uh oh!
There was an error while loading. Please reload this page.
bpo-5028: fix doc bug for tokenize - #11683
Conversation
the-knights-who-say-ni
commented
Jan 26, 2019
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
andrewnc
commented
Jan 28, 2019
via email
I signed the CLA on Saturday …On Mon, Jan 28, 2019, 3:13 AM Emmanuel Arias ***@***.*** wrote:
***@***.**** approved this pull request.
LGTM. Please, sign CLA.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11683 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHW-Mlytv8CXRHd_CQcbA5LVzmkQLc_gks5vHs1UgaJpZM4aUTNb>
.
|
asottile
commented
Jan 31, 2019
I think the "continuation lines are included" bit should be dropped from the doc as well (since it's irrelevant for physical lines) |
csabella
commented
May 30, 2019
@andrewnc, thank you for your first contribution to CPython! 🎉 |
asottile
commented
May 30, 2019
@csabella oh, I was hoping this would get addressed as part of this PR -- oh well :) |
csabella
commented
May 30, 2019
@asottile, yes, I probably should have requested that change before merging, but I didn't want to drag this one out. If you can, please open another PR with that change and I'll see if we can get a quick review on it. Thanks! |
https://bugs.python.org/issue5028