Skip to content

gh-116145: Updated bundled Tcl/Tk on Windows to 8.6.14 - #117030

Merged
zooba merged 3 commits into
python:mainfrom
zooba:gh-116145
May 31, 2024
Merged

gh-116145: Updated bundled Tcl/Tk on Windows to 8.6.14#117030
zooba merged 3 commits into
python:mainfrom
zooba:gh-116145

Conversation

@zooba

@zoobazooba commented Mar 19, 2024

Copy link
Copy Markdown
Member

@zooba
zooba requested a review from sethmlarson as a code ownerMarch 19, 2024 19:39
@terryjreedy

terryjreedy commented Mar 20, 2024

Copy link
Copy Markdown
Member

@chrstphrchvz knows about tcl/tk changes.
@serhiy-storchaka is tkinter/ttk code and test maintainer.

Windows x86 test https://github.com/python/cpython/actions/runs/8349119889/job/22852588108?pr=117030

*** test tkinter 2 failures: lines 2001-2061
condensed failure:

FAIL: test_itemconfigure (test.test_tkinter.test_widgets.ListboxTest.test_itemconfigure)
File "D:\a\cpython\cpython\Lib\test\test_tkinter\test_widgets.py", line 1002, in test_itemconfigure
self.assertEqual(widget.itemconfigure(0, 'background'),
AssertionError: Tuples differ: ('background', '', '', '', 'red') != ('background', 'background', 'Background', '', 'red')
FAIL: test_configure_tabs (test.test_tkinter.test_widgets.TextTest.test_configure_tabs)
File "D:\a\cpython\cpython\Lib\test\test_tkinter\test_widgets.py", line 662, in test_configure_tabs
self.checkParam(widget, 'tabs', '10.2 20.7 1i 2i',
AssertionError: Tuples differ: (10.2, 20.7, <string object: '1i'>, <string object: '2i'>) != ('10.2', '20.7', '1i', '2i')

*** test audit 1 failure, lines 980-1070: Broken pipe error
I know nothing about this. It passed on rerun, same fail, OK on x64, no failure on free-threading builds.
Perhaps ignore for now.

*** test_ttk failed (8 failures) lines 2066-2265
All are same quoting issue: actual (0,) expected as ('0',).

@zooba
zooba merged commit 0e8d35b into python:mainMay 31, 2024
@zooba
zooba deleted the gh-116145 branch May 31, 2024 12:07
@zoobazooba added the needs backport to 3.13 bugs and security fixes label May 31, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2024
…H-117030)
(cherry picked from commit 0e8d35b)
Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app

Copy link
Copy Markdown

GH-119847 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 31, 2024
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.12 only security fixes label May 31, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @zooba, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0e8d35b931f41210483cc51c4169e9a943c7f166 3.12

zooba added a commit that referenced this pull request May 31, 2024
(cherry picked from commit 0e8d35b)
Co-authored-by: Steve Dower <steve.dower@python.org>
@zooba

Copy link
Copy Markdown
MemberAuthor

The macOS change was not backported to 3.12. I don't remember whether we'd consider this a bugfix or a suitable-for-post-beta-pre-RC change, but I'm happy enough to leave it to 3.13 only.

@bedevere-bot

This comment was marked as resolved.

@terryjreedy

Copy link
Copy Markdown
Member

Hid buildbot failure because test_math and test_statistics not affected by tkinter.

@serhiy-storchaka

Copy link
Copy Markdown
Member

8.6.14 is a bugfix release. Is there a way for Windows users to update the Tcl/Tk version independently?

@zooba

Copy link
Copy Markdown
MemberAuthor

Better discuss on the issue, since the macOS maintainers are almost certainly not watching this PR.

@zoobazooba removed their assignment Jun 3, 2024
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Jun 12, 2024
…ythonGH-117030)
(cherry picked from commit 0e8d35b)
Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app

Copy link
Copy Markdown

GH-120396 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Jun 12, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba@terryjreedy@bedevere-bot@serhiy-storchaka@zware