Uh oh!
There was an error while loading. Please reload this page.
[3.11] gh-116333: Relax error string text expectations in SSL-related tests (GH-116334) - #117227
Closed
WillChilds-Klein wants to merge 2 commits into
Closed
[3.11] gh-116333: Relax error string text expectations in SSL-related tests (GH-116334)#117227WillChilds-Klein wants to merge 2 commits into
WillChilds-Klein wants to merge 2 commits into
Conversation
This was referenced Mar 25, 2024
gpshead
approved these changes
Mar 25, 2024
WillChilds-Kleinforce-pushed
the
3.11-relax-ssl-err-strs
branch
from
March 25, 2024 20:56
c22dbe1 to
1672218CompareWillChilds-Klein
marked this pull request as ready for review
March 25, 2024 21:11
WillChilds-Kleinforce-pushed
the
3.11-relax-ssl-err-strs
branch
from
March 27, 2024 01:45
55a698e to
ced2248Comparebedevere-bot
commented
Mar 27, 2024
…tests (pythonGH-116334) As suggested [here][1], this change relaxes the OpenSSL error string text expectations in a number of tests. This was specifically done in support of more easily building CPython [AWS-LC][2], but because AWS-LC is a fork of [BoringSSL][3], it should increase compatibility with that library as well. In addition to the error string relaxations, we also add some guards around the `tls-unique` channel binding being used with TLSv1.3, as that feature (described in [RFC 6929][4]) is [not defined][5] for TLSv1.3. [1]: https://discuss.python.org/t/support-building-ssl-and-hashlib-modules-against-aws-lc/44505/4 [2]: https://github.com/aws/aws-lc [3]: https://github.com/google/boringssl [4]: https://datatracker.ietf.org/doc/html/rfc5929#section-3 [5]: https://datatracker.ietf.org/doc/html/rfc8446#appendix-C.5
WillChilds-Kleinforce-pushed
the
3.11-relax-ssl-err-strs
branch
from
March 29, 2024 16:14
ced2248 to
ffbd007CompareMember
3.11 now accepts security patches only (see https://devguide.python.org/versions/ for the timeline and https://peps.python.org/pep-0664/#bugfix-releases for the schedule). Should we close this bugfix PR then? |
WillChilds-Klein
commented
Apr 10, 2024
ContributorAuthor
Hi @arhadthedev, thank you for the links and head's up. I'll close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #116334 to the 3.11 branch.