Uh oh!
There was an error while loading. Please reload this page.
GH-116380: Add tests for glob.glob0() and glob.glob1(). - #117305
GH-116380: Add tests for glob.glob0() and glob.glob1().#117305barneygale wants to merge 1 commit into
glob.glob0() and glob.glob1().#117305Conversation
These undocumented functions expand a single literal or (non-recursive) wildcard segment.
serhiy-storchaka
commented
Mar 28, 2024
They are undocumented and no longer used in the stdlib. |
barneygale
commented
Mar 28, 2024
Indeed. But they're used by third-party code, and neither deprecated nor underscore-prefixed. |
serhiy-storchaka
commented
Mar 28, 2024
They are not underscored because this is not needed. Opened #117337. |
barneygale
commented
Mar 28, 2024
Does deprecating these functions preclude the addition of tests in your view? |
serhiy-storchaka
commented
Mar 28, 2024
The new tests LGTM. Some tests will be needed for deprecation anyway. But all tests added in this PR will be changed, and maybe moved to other place. This will only increase the size of the logs. Would you mind creating a PR to deprecate these functions, along with adding new tests? Or do you prefer merging this PR first? |
barneygale
commented
Mar 29, 2024
Good shout. I've opened #117371 to deprecate the functions, and incorporated the tests there. I'll close this PR! |
These undocumented functions expand a single literal or (non-recursive) wildcard segment.
glob.glob()by reducing number of system calls made #116380