Skip to content

gh-116749: Run test suite with the GIL disabled - #117437

Closed
colesbury wants to merge 24 commits into
python:mainfrom
colesbury:nogil-integration
Closed

gh-116749: Run test suite with the GIL disabled#117437
colesbury wants to merge 24 commits into
python:mainfrom
colesbury:nogil-integration

Conversation

@colesbury

@colesburycolesbury commented Apr 1, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This is a combination of a few unmerged PRs to test running with the GIL disabled in the free-threaded build.

@bedevere-appbedevere-appBot mentioned this pull request Apr 1, 2024
Closed
@colesbury

colesbury commented Apr 1, 2024

Copy link
Copy Markdown
ContributorAuthor

!buildbot nogil

@bedevere-bot

bedevere-bot commented Apr 1, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 367ccf0 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • AMD64 Ubuntu NoGIL PR
  • x86-64 MacOS Intel NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • ARM64 MacOS M1 NoGIL PR

@colesbury

colesbury commented Apr 2, 2024

Copy link
Copy Markdown
ContributorAuthor

!buildbot nogil

@bedevere-bot

bedevere-bot commented Apr 2, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit dcfe6bc 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • AMD64 Ubuntu NoGIL PR
  • x86-64 MacOS Intel NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • ARM64 MacOS M1 NoGIL PR

@colesbury

colesbury commented Apr 2, 2024

Copy link
Copy Markdown
ContributorAuthor

!buildbot nogil

@bedevere-bot

bedevere-bot commented Apr 2, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 0d1ed96 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • AMD64 Ubuntu NoGIL PR
  • x86-64 MacOS Intel NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • ARM64 MacOS M1 NoGIL PR

@colesbury
colesburyforce-pushed the nogil-integration branch 2 times, most recently from bf23f92 to ffa9641CompareApril 8, 2024 18:43
@colesbury

colesbury commented Apr 8, 2024

Copy link
Copy Markdown
ContributorAuthor

!buildbot nogil

@bedevere-bot

bedevere-bot commented Apr 8, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 3d681c3 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel NoGIL PR
  • ARM64 MacOS M1 NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR

@colesbury

colesbury commented Apr 9, 2024

Copy link
Copy Markdown
ContributorAuthor

!buildbot nogil

@bedevere-bot

bedevere-bot commented Apr 9, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit b856049 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel NoGIL PR
  • ARM64 MacOS M1 NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR

@colesbury

colesbury commented Apr 9, 2024

Copy link
Copy Markdown
ContributorAuthor

!buildbot nogil

@bedevere-bot

bedevere-bot commented Apr 9, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 29b7243 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel NoGIL PR
  • ARM64 MacOS M1 NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR

@colesbury

colesbury commented Apr 12, 2024

Copy link
Copy Markdown
ContributorAuthor

!buildbot nogil

@bedevere-bot

bedevere-bot commented Apr 12, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 73c8d7c 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • AMD64 Ubuntu NoGIL Refleaks PR
  • x86-64 MacOS Intel NoGIL PR
  • x86-64 MacOS Intel ASAN NoGIL PR
  • ARM64 MacOS M1 NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR

DinoVand others added 17 commits April 19, 2024 09:48
@DinoV
Refactor del/set into set_or_del_lock_held, and avoid locking on newl…
319f632
…y materialized dict
Fix duplicate incref
Fix comment
Remove redundant if check on detach
@DinoV
tracing thread safety
2f6ca58
@DinoV
Lock on allocation, use version as sync point
fe19d59
@DinoV
Lock in non-debug builds
210b802
@DinoV
Move CHECK_EVAL_BREAKER in ENTER_EXECUTOR
597f40d
@DinoV
Don't potentially leak executor
8393bfe
@DinoV
Just use _Py_atomic_exchange_ptr instead of FT macro
65ff505
@DinoV
Use FT_ATOMIC_LOAD_UINTPTR_ACQUIRE for INSTRUMENTED_RESUME too
6e19601
@DinoV
Handle dict replacement case better
8860a7f
@DinoV
Decref materialized dict on fail to set
4b85255
@colesbury
pythongh-117783: Immortalize objects that use deferred reference coun…
30a4133
…ting
Deferred reference counting is not fully implemented yet. As a temporary
measure, we immortalize objects that would use deferred reference
counting to avoid multi-threaded scaling bottlenecks.
This is only performed in the free-threaded build once the first
non-main thread is started. Additionally, some tests, including refleak
tests, suppress this behavior.
@colesbury
Fix set_immortalize_deferred
0cab82c
@colesbury
Merge branch 'disable-gil-default' into nogil-integration
c716f32
@colesbury
Merge branch 'nogil_dict_pydictvalues' into nogil-integration
eb8ebe4
@colesbury
Merge branch 'nogil_settrace' into nogil-integration
74eec36
@colesbury
Merge branch 'pythongh-112075-lock-split-keys' into nogil-integration
a825875
@colesbury
Merge branch 'pythongh-117783-immortalize' into nogil-integration
539595a
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 will be requested when the pull request is marked ready for reviewkumaraditya303 is a code owner
@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger will be requested when the pull request is marked ready for reviewrhettinger is a code owner
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently will be requested when the pull request is marked ready for reviewericsnowcurrently is a code owner
@ZeroIntensityZeroIntensityAwaiting requested review from ZeroIntensityZeroIntensity will be requested when the pull request is marked ready for reviewZeroIntensity is a code owner
@FFY00FFY00Awaiting requested review from FFY00FFY00 will be requested when the pull request is marked ready for reviewFFY00 is a code owner
@brandtbucherbrandtbucherAwaiting requested review from brandtbucherbrandtbucher will be requested when the pull request is marked ready for reviewbrandtbucher is a code owner
@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski will be requested when the pull request is marked ready for reviewsavannahostrowski is a code owner
@diegorussodiegorussoAwaiting requested review from diegorussodiegorusso will be requested when the pull request is marked ready for reviewdiegorusso is a code owner
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon will be requested when the pull request is marked ready for reviewmarkshannon is a code owner
@methanemethaneAwaiting requested review from methanemethane will be requested when the pull request is marked ready for reviewmethane is a code owner
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland will be requested when the pull request is marked ready for reviewerlend-aasland is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner will be requested when the pull request is marked ready for reviewAA-Turner is a code owner
@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping will be requested when the pull request is marked ready for reviewemmatyping is a code owner
@itamaroitamaroAwaiting requested review from itamaroitamaro will be requested when the pull request is marked ready for reviewitamaro is a code owner

Assignees

No one assigned

Labels

DO-NOT-MERGEskip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colesbury@bedevere-bot@DinoV