Uh oh!
There was an error while loading. Please reload this page.
gh-117394: Speed up os.path.ismount() on Posix - #117447
Merged
serhiy-storchaka merged 2 commits intoApr 17, 2024
Merged
Conversation
It is now 2-3 times faster if the user has permissions.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Benchmark: # test.shecho"relative"&& python -m timeit -s "import before.posixpath""before.posixpath.ismount('.')"&& python -m timeit -s "import after.posixpath""after.posixpath.ismount('.')"echo"absolute"&& python -m timeit -s "import before.posixpath""before.posixpath.ismount('/Volumes/2GB_001')"&& python -m timeit -s "import after.posixpath""after.posixpath.ismount('/Volumes/2GB_001')"echo"no permission"&& python -m timeit -s "import before.posixpath""before.posixpath.ismount('/Users/wannes/path-picker/permission-test/dirs/666')"&& python -m timeit -s "import after.posixpath""after.posixpath.ismount('/Users/wannes/path-picker/permission-test/dirs/666')" |
Uh oh!
There was an error while loading. Please reload this page.
nineteendo
approved these changes
Apr 3, 2024
nineteendo
commented
Apr 10, 2024
Contributor
@erlend-aasland, could you review this? |
erlend-aasland
commented
Apr 11, 2024
Contributor
Looks good to me, but I'm not sure if it worth the added maintenance cost to optimise this. I mean, how often is the |
diegorusso pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
It is now 2-3 times faster if the user has permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is now 2-3 times faster if the user has permissions.
posixpath.ismount#117394