Skip to content

gh-117431: Adapt bytes and bytearray .startswith() and .endswith() to Argument Clinic - #117495

Merged
erlend-aasland merged 11 commits into
python:mainfrom
erlend-aasland:perf/bytes.starwith
Apr 3, 2024
Merged

gh-117431: Adapt bytes and bytearray .startswith() and .endswith() to Argument Clinic#117495
erlend-aasland merged 11 commits into
python:mainfrom
erlend-aasland:perf/bytes.starwith

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

This change gives a significant speedup, as the METH_FASTCALL calling convention is now used.

@erlend-aasland

erlend-aasland commented Apr 3, 2024

Copy link
Copy Markdown
ContributorAuthor

Release build on macOS:

# main
$ ./python.exe -m timeit -s "b = b'abcdef'""b.startswith(b'abc')"5000000 loops, best of 5: 89.6 nsec per loop
# this PR
$ ./python.exe -m timeit -s "b = b'abcdef'""b.startswith(b'abc')"10000000 loops, best of 5: 27.3 nsec per loop

Comment threadObjects/bytesobject.c Outdated
Comment threadObjects/bytearrayobject.c Outdated
@bedevere-app

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Comment threadObjects/bytesobject.c
Comment threadObjects/bytesobject.c Outdated
@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review, Inada-san!

@erlend-aasland
erlend-aasland merged commit 595bb49 into python:mainApr 3, 2024
@erlend-aasland
erlend-aasland deleted the perf/bytes.starwith branch April 3, 2024 11:11
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…h() to Argument Clinic (python#117495)
This change gives a significant speedup, as the METH_FASTCALL calling
convention is now used.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@erlend-aasland@methane