Skip to content

gh-117431: Adapt bytes and bytearray .find() and friends to Argument Clinic - #117502

Merged
erlend-aasland merged 28 commits into
python:mainfrom
erlend-aasland:perf/bytes.find-and-friends
Apr 12, 2024
Merged

gh-117431: Adapt bytes and bytearray .find() and friends to Argument Clinic#117502
erlend-aasland merged 28 commits into
python:mainfrom
erlend-aasland:perf/bytes.find-and-friends

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Apr 3, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This change gives a significant speedup, as the METH_FASTCALL calling convention is used.

@bedevere-appbedevere-appBot mentioned this pull request Apr 3, 2024
Open
@erlend-aaslanderlend-aasland changed the title gh-117431: Adapt bytes abnd bytearray .find() and friends to Argument Clinicgh-117431: Adapt bytes and bytearray .find() and friends to Argument ClinicApr 3, 2024
@erlend-aasland

erlend-aasland commented Apr 3, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Note that the diff is not as frightening as GitHub wants it; subtract the generated files, and the diff is within ~200 lines of code, most of it being clinic input blocks.

Moreover, we want to update either this PR or #117468 to remove the auxiliary stringlib functions, depending on which PR lands first. UPDATE: aux stringlib function is now removed.

@erlend-aasland

erlend-aasland commented Apr 10, 2024

Copy link
Copy Markdown
ContributorAuthor

@methane, I intend to merge this in time for the beta in May. Aiming to land it next week.

methane
methane reviewed Apr 12, 2024
View reviewed changes

@methanemethane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although old docstring used [start,end], I want to fix them to [start:end].

Comment threadObjects/bytearrayobject.c Outdated
Comment threadObjects/bytearrayobject.c Outdated
Comment threadObjects/bytearrayobject.c Outdated
Comment threadObjects/bytearrayobject.c Outdated
@erlend-aasland@methane
Apply suggestions from code review
d671524
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@erlend-aasland

erlend-aasland commented Apr 12, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review, Inada-san!

erlend-aaslandand others added 2 commits April 12, 2024 09:04
@erlend-aasland@methane
Update Objects/bytearrayobject.c
747ecf9
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@erlend-aasland
Again
0ad3919
@erlend-aasland
erlend-aasland enabled auto-merge (squash) April 12, 2024 07:07
@erlend-aasland
erlend-aasland merged commit deb921f into python:mainApr 12, 2024
@erlend-aasland
erlend-aasland deleted the perf/bytes.find-and-friends branch April 12, 2024 07:40
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@erlend-aasland@methane@diegorusso
pythongh-117431: Adapt bytes and bytearray .find() and friends to Arg…
12e5501
…ument Clinic (python#117502)
This change gives a significant speedup, as the METH_FASTCALL calling
convention is now used. The following bytes and bytearray methods are adapted:
- count()
- find()
- index()
- rfind()
- rindex()
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methanemethanemethane left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erlend-aasland@methane