Skip to content

gh-113317: Finish splitting Argument Clinic into sub-files - #117513

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:ac_split
Apr 4, 2024
Merged

gh-113317: Finish splitting Argument Clinic into sub-files#117513
vstinner merged 1 commit into
python:mainfrom
vstinner:ac_split

Conversation

@vstinner

@vstinnervstinner commented Apr 3, 2024

Copy link
Copy Markdown
Member

Add libclinic.parser module and move the following classes and functions there:

  • Parser
  • PythonParser
  • create_parser_namespace()

Add libclinic.dsl_parser module and move the following classes, functions and variables there:

  • ConverterArgs
  • DSLParser
  • FunctionNames
  • IndentStack
  • ParamState
  • StateKeeper
  • eval_ast_expr()
  • unsupported_special_methods

Add libclinic.app module and move the Clinic class there.

Add libclinic.cli module and move the following functions there:

  • create_cli()
  • main()
  • parse_file()
  • run_clinic()

Add libclinic.parser module and move the following classes and
functions there:
* Parser
* PythonParser
* create_parser_namespace()
Add libclinic.dsl_parser module and move the following classes,
functions and variables there:
* ConverterArgs
* DSLParser
* FunctionNames
* IndentStack
* ParamState
* StateKeeper
* eval_ast_expr()
* unsupported_special_methods
Add libclinic.app module and move the Clinic class there.
Add libclinic.cli module and move the following functions there:
* create_cli()
* main()
* parse_file()
* run_clinic()
Comment threadTools/clinic/libclinic/app.py
@vstinner

Copy link
Copy Markdown
MemberAuthor

See also #115542

@vstinner

Copy link
Copy Markdown
MemberAuthor

Merged, thanks for the review @erlend-aasland.

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…hon#117513)
Add libclinic.parser module and move the following classes and
functions there:
* Parser
* PythonParser
* create_parser_namespace()
Add libclinic.dsl_parser module and move the following classes,
functions and variables there:
* ConverterArgs
* DSLParser
* FunctionNames
* IndentStack
* ParamState
* StateKeeper
* eval_ast_expr()
* unsupported_special_methods
Add libclinic.app module and move the Clinic class there.
Add libclinic.cli module and move the following functions there:
* create_cli()
* main()
* parse_file()
* run_clinic()
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Argument Clinic: split out global stateless helpers and constants from clinic.py

2 participants

@vstinner@erlend-aasland