Skip to content

gh-117531: Unblock getters after non-immediate queue shutdown - #117532

Merged
gvanrossum merged 10 commits into
python:mainfrom
EpicWink:queue-shutdown-unblock-get
Apr 10, 2024
Merged

gh-117531: Unblock getters after non-immediate queue shutdown#117532
gvanrossum merged 10 commits into
python:mainfrom
EpicWink:queue-shutdown-unblock-get

Conversation

@EpicWink

@EpicWinkEpicWink commented Apr 4, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Apr 4, 2024
Closed
@EpicWink
EpicWinkforce-pushed the queue-shutdown-unblock-get branch from 8bb6fae to 5d490b3CompareApril 4, 2024 02:09
@EpicWinkEpicWink mentioned this pull request Apr 4, 2024
Merged
@rhettinger
rhettinger removed their request for review April 4, 2024 02:16
YvesDup
YvesDup reviewed Apr 4, 2024
View reviewed changes
Comment threadLib/test/test_queue.py Outdated
YvesDup
YvesDup reviewed Apr 4, 2024
View reviewed changes
Comment threadLib/test/test_queue.py Outdated
@YvesDup

YvesDup commented Apr 6, 2024

Copy link
Copy Markdown
Contributor

Regarding my last comments, docstring of shutdown method (and related documentation - I didn't check) must be modified about 'blocked callers'.

YvesDup
YvesDup reviewed Apr 8, 2024
View reviewed changes
Comment threadLib/queue.py
@YvesDup

YvesDup commented Apr 8, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

I approved the last commits and I'm waiting for the last comment to be approve (or not).

@YvesDup

YvesDup commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

I approve

@YvesDup

YvesDup commented Apr 10, 2024

Copy link
Copy Markdown
Contributor

@gvanrossum Sorry, I forget to tell you that I've approved

@gvanrossum
gvanrossum merged commit 6bc0b33 into python:mainApr 10, 2024
@EpicWink
EpicWink deleted the queue-shutdown-unblock-get branch April 11, 2024 01:06
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@EpicWink@diegorusso
pythongh-117531: Unblock getters after non-immediate queue shutdown (p…
56927d4
…ython#117532)
(This is a small tweak of the original pythongh-104750 which added shutdown.)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes
+1 more reviewer
@YvesDupYvesDupYvesDup left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EpicWink@YvesDup@gvanrossum