Skip to content

gh-113317: Rename libclinic to argclinic - #117533

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:rename_argclinic
Closed

gh-113317: Rename libclinic to argclinic#117533
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:rename_argclinic

Conversation

@vstinner

@vstinnervstinner commented Apr 4, 2024

Copy link
Copy Markdown
Member
  • Rename Tools/clinic/libclinic/ to Tools/clinic/argclinic/
  • Rename Tools/clinic/clinic.py to Tools/clinic/run_argclinic.py.
  • Add Tools/clinic/argclinic/main.py.
  • Convert absolute imports to imports related to the packages. For example, replace "from libclinic.cli import main" with "from .cli import main".
  • Remove "import clinic": import individual names.
  • "make clinic" now runs "python -m clinic".

* Rename Tools/clinic/libclinic/ to Tools/clinic/argclinic/
* Rename Tools/clinic/clinic.py to Tools/clinic/run_argclinic.py.
* Add Tools/clinic/argclinic/__main__.py.
* Convert absolute imports to imports related to the packages. For
example, replace "from libclinic.cli import main" with
"from .cli import main".
* Remove "import clinic": import individual names.
* "make clinic" now runs "python -m clinic".
@vstinner

Copy link
Copy Markdown
MemberAuthor

@erlend-aasland: Here is a proposition to replace python clinic.py script with python -m argclinic (add __main__.py).

I also renamed "clinic" to "argclinic" to have a more specific name (be more explicit about the reference to the Monty Python sketch).

The PR is a little bit bigger than expect since there were still a few files importing libclinic to get many functions, rather than importing sub-modules.

@erlend-aasland

Copy link
Copy Markdown
Contributor

What is the rationale for this change?

@vstinner

Copy link
Copy Markdown
MemberAuthor

What is the rationale for this change?

My long term goal is to distribute Argument Clinic on PyPI. But I know that you disagree with that. I prefer to close this PR for now.

@vstinner
vstinner deleted the rename_argclinic branch April 15, 2024 14:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@erlend-aasland