Skip to content

gh-117431: Argument Clinic: copy forced text signature when cloning - #117591

Merged
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/clone-text-signature
Apr 10, 2024
Merged

gh-117431: Argument Clinic: copy forced text signature when cloning#117591
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/clone-text-signature

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Apr 6, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aaslanderlend-aasland changed the title Argument Clinic: copy forced text signature when cloninggh-117431: Argument Clinic: copy forced text signature when cloningApr 6, 2024
@bedevere-appbedevere-appBot mentioned this pull request Apr 6, 2024
Open
@erlend-aasland
erlend-aasland marked this pull request as ready for review April 6, 2024 20:46
vstinner
vstinner approved these changes Apr 8, 2024
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can ignore my suggestion on using a non-empty docstring.

Comment threadLib/test/test_clinic.py
serhiy-storchaka
serhiy-storchaka reviewed Apr 9, 2024
View reviewed changes
Comment threadTools/clinic/libclinic/dsl_parser.py
@erlend-aasland

erlend-aasland commented Apr 9, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review, @vstinner. I expanded the tests.

serhiy-storchaka
serhiy-storchaka approved these changes Apr 9, 2024
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erlend-aasland

erlend-aasland commented Apr 9, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review, Serhiy! I'll land this tomorrow.

@erlend-aaslanderlend-aasland mentioned this pull request Apr 9, 2024
Closed
@erlend-aasland
erlend-aasland merged commit 0d42ac9 into python:mainApr 10, 2024
@erlend-aasland
erlend-aasland deleted the clinic/clone-text-signature branch April 10, 2024 08:12
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@erlend-aasland@diegorusso
pythongh-117431: Argument Clinic: copy forced text signature when clo…
c8f5d96
…ning (python#117591)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erlend-aasland@vstinner@serhiy-storchaka