Uh oh!
There was an error while loading. Please reload this page.
bpo-35766 follow-up: Add an error check to new_type_comment() - #11766
Merged
Conversation
If PyUnicode_DecodeUTF8() returns NULL, PyArena_AddPyObject() would crash. Found by @msullivan for python/typed_ast#93.
bedevere-bot
commented
Feb 11, 2019
@gvanrossum: Please replace |
bedevere-bot
commented
Feb 11, 2019
|
gvanrossum
commented
Feb 11, 2019
MemberAuthor
I believe the buildbot failure is a false positive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If PyUnicode_DecodeUTF8() were to return
NULL,PyArena_AddPyObject()would crash.Found by @msullivan for python/typed_ast#93.
https://bugs.python.org/issue35766