Skip to content

gh-117711: Fix test_tools.test_makefile when wheeldata dir is empty - #117748

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:wheeldata
Closed

gh-117711: Fix test_tools.test_makefile when wheeldata dir is empty#117748
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:wheeldata

Conversation

@vstinner

@vstinnervstinner commented Apr 11, 2024

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Apr 11, 2024
@vstinner
vstinner marked this pull request as ready for review April 11, 2024 09:25
@vstinner

Copy link
Copy Markdown
MemberAuthor

@sobolevn: Would you mind to review this change?

You can test the change using rm -f Lib/test/wheeldata/*. Without this change, ./python -m test -v test_tools.test_makefile fails. With this change, it works.

@hroncok

hroncok commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

I kinda prefer gh-117712.

Your approach works too, but makes the test pass even if the folder is accidentally empty.

(If we are extra paranoid, we can combine both conditionals into one, but I don't think it's necessary.)

@vstinner

Copy link
Copy Markdown
MemberAuthor

I merged PR gh-117712 instead. I close my PR.

I kinda prefer #117712. Your approach works too, but makes the test pass even if the folder is accidentally empty.

I agree with you :-) I prefer PR gh-117712 approach.

@vstinner
vstinner deleted the wheeldata branch April 11, 2024 09:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core reviewskip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@hroncok