Skip to content

[3.12] gh-117114: Update availability and source code link in os.path.rst - #117756

Merged
zooba merged 1 commit into
python:3.12from
nineteendo:link-to-genericpath
Apr 15, 2024
Merged

[3.12] gh-117114: Update availability and source code link in os.path.rst#117756
zooba merged 1 commit into
python:3.12from
nineteendo:link-to-genericpath

Conversation

@nineteendo

@nineteendonineteendo commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

I added a link to Lib/genericpath.py in the documentation of os.path (and removed the redundant availability notes) in this pull request: #117115, but this wasn't backported.

Note: the other changes in this pull request are NOT being backported.


📚 Documentation preview 📚: https://cpython-previews--117756.org.readthedocs.build/

@bedevere-appbedevere-appBot added docs Documentation in the Doc dir skip news labels Apr 11, 2024
@nineteendo
nineteendo marked this pull request as ready for review April 11, 2024 15:03
@nineteendo

Copy link
Copy Markdown
ContributorAuthor

@erlend-aasland, could you add the skip-issue label? Or must I first make an issue for this?

@erlend-aasland

Copy link
Copy Markdown
Contributor

@erlend-aasland, could you add the skip-issue label? Or must I first make an issue for this?

AFAICS, this belongs to gh-117114.

@erlend-aaslanderlend-aasland changed the title [3.12] Link to genericpath[3.12] gh-117114: Update availability and source code link in os.path.rstApr 11, 2024
@bedevere-appbedevere-appBot mentioned this pull request Apr 11, 2024
@erlend-aasland

Copy link
Copy Markdown
Contributor

Are you sure about those availability adjustments?

@nineteendo

Copy link
Copy Markdown
ContributorAuthor

Yeah, when a function is defined in both Lib/ntpath.py & Lib/posixpath.py, it's available on all platforms.

I also think I know why these availability notes are here: these functions weren't available in macpath, and the notes weren't removed together with it: d7538dd.

@nineteendo

Copy link
Copy Markdown
ContributorAuthor

@zooba, thoughts?

@nineteendo

Copy link
Copy Markdown
ContributorAuthor

@AlexWaygood, do you have an opinion on this?

@zooba

Copy link
Copy Markdown
Member

I also think I know why these availability notes are here: these functions weren't available in macpath, and the notes weren't removed together with it

That and probably a few were only available on one, and then when we added the other we added to the list rather than removing the list.

This looks good to me.

@zooba
zooba merged commit 2dcb267 into python:3.12Apr 15, 2024
@nineteendo
nineteendo deleted the link-to-genericpath branch April 15, 2024 15:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nineteendo@erlend-aasland@zooba