Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 35.2k
gh-117764: Fix and add signatures for many builtins#117769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -3255,6 +3255,9 @@ PyDoc_STRVAR(memory_f_contiguous_doc, | ||||||||||||||||||||
| "A bool indicating whether the memory is Fortran contiguous."); | ||||||||||||||||||||
| PyDoc_STRVAR(memory_contiguous_doc, | ||||||||||||||||||||
| "A bool indicating whether the memory is contiguous."); | ||||||||||||||||||||
| PyDoc_STRVAR(memory_exit_doc, | ||||||||||||||||||||
| "__exit__($self, /, *exc_info)\n--\n\n" | ||||||||||||||||||||
| "Release the underlying buffer exposed by the memoryview object."); | ||||||||||||||||||||
Comment on lines
+3258
to
+3260
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
(maybe the signature for enter is not correct, it returns a reference to itself) MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is rather the side effect. MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I left this for future. The | ||||||||||||||||||||
| static PyGetSetDef memory_getsetlist[] = { | ||||||||||||||||||||
| @@ -3283,7 +3286,7 @@ static PyMethodDef memory_methods[] = { | ||||||||||||||||||||
| MEMORYVIEW_TOREADONLY_METHODDEF | ||||||||||||||||||||
| MEMORYVIEW__FROM_FLAGS_METHODDEF | ||||||||||||||||||||
| {"__enter__", memory_enter, METH_NOARGS, NULL}, | ||||||||||||||||||||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||||||||||||||||
| {"__exit__", memory_exit, METH_VARARGS, NULL}, | ||||||||||||||||||||
| {"__exit__", memory_exit, METH_VARARGS, memory_exit_doc}, | ||||||||||||||||||||
| {NULL, NULL} | ||||||||||||||||||||
| }; | ||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -225,9 +225,9 @@ static PyMethodDef namespace_methods[] = { | ||
| PyDoc_STRVAR(namespace_doc, | ||
| "A simple attribute-based namespace.\n\ | ||
| \n\ | ||
| SimpleNamespace(**kwargs)"); | ||
| "SimpleNamespace(**kwargs)\n\ | ||
erlend-aasland marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| --\n\n\ | ||
| A simple attribute-based namespace."); | ||
| PyTypeObject _PyNamespace_Type = { | ||
| PyVarObject_HEAD_INIT(&PyType_Type, 0) | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.