Uh oh!
There was an error while loading. Please reload this page.
gh-96398: Purge Emscripten code from configure.ac - #117836
Conversation
See pythongh-113632 and python/peps#3612: Emscripten is no longer supported
This comment was marked as outdated.
This comment was marked as outdated.
erlend-aasland
commented
Apr 13, 2024
cc. @corona10 |
corona10
commented
Apr 13, 2024
What about this change? #117819 |
erlend-aasland
commented
Apr 13, 2024
IMO that should remain. We want to filter emcc out in |
But this code is no reason to remain if we purge them no? |
erlend-aasland
commented
Apr 13, 2024
emcc also defines |
Okay, so to filter out emcc, we need emcc :( Would you like to add a comment on that code to annotate that we do not support each according to PEP? |
erlend-aasland
commented
Apr 13, 2024
Or to put it another way: to filter out emcc, we need to know how to identify it :)
We already have the switch in L1130. Did you think about a comment in the check that defines |
erlend-aasland
commented
Apr 13, 2024
Alternatively, we can just keep this code; there is not a huge maintenance burden; a solution could be to add a comment above the lines that are proposed to be purged by this PR. |
vstinner
commented
Apr 15, 2024
I don't get why this code has to be removed right now. CPython is full of code specific to "unsupported" platforms such as MinGW or OpenBSD. There are CPython users using this build mode: build CPython for the browser. |
erlend-aasland
commented
Apr 15, 2024
Yes, let's go with my suggestion from #117836 (comment). |
vstinner
commented
Apr 16, 2024
"CPython in the browser" is a top topic with https://pyodide.org/ and https://pyscript.net/ projects. |
See gh-113632 and python/peps#3612: Emscripten is no longer supported