Uh oh!
There was an error while loading. Please reload this page.
gh-117587: Add C implementation of os.path.abspath - #117855
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nineteendo
commented
Apr 14, 2024
The same approach doesn't work on Window, because PS C:\Users\wanne\cpython> python -m timeit -s "import nt""nt._getfullpathname('.')"; python -m timeit -s "import os""os.path.join(r'C:\Users\wanne\cpython', '')"1000000 loops, best of 5: 286 nsec per loop # _getfullpathname200000 loops, best of 5: 1.41 usec per loop # join |
This comment was marked as resolved.
This comment was marked as resolved.
nineteendo
commented
Apr 14, 2024
I didn't even get that far in the testing process. I already knew it wasn't going to work. |
…endo/cpython into speedup-posixpath.abspath
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Thanks for making the requested changes! @erlend-aasland: please review the changes made to this pull request. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
nineteendo
commented
May 30, 2024
erlend-aasland, I have made the requested changes; please review again. |
Thanks for making the requested changes! @erlend-aasland: please review the changes made to this pull request. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Benchmark
posixpath.py by @eryksun:
ntpath.py
script
posixpath.abspath()for relative paths #117587