Uh oh!
There was an error while loading. Please reload this page.
GH-115480: Reduce guard strength for binary ops when type of one operand is known already - #118050
Merged
Merged
Conversation
gvanrossum
approved these changes
Apr 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
Fidget-Spinner
approved these changes
Apr 18, 2024
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
markshannon
commented
Apr 22, 2024
MemberAuthor
The four failures are a pre-existing issue with emulated ARM 64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
_GUARD_TOS_INT/FLOAT,_GUARD_NOS_INT/FLOATand float variants and replaces_GUARD_BOTH_INT/FLOATwith them where able.The stats show an 83% reduction in
_GUARD_BOTH_INTand a 42% reduction in_GUARD_BOTH_FLOAT.BINARY_OP#115480