Uh oh!
There was an error while loading. Please reload this page.
Correct the argument names for secrets.choice and secrets.randbelow in secrets.rst - #118098
Merged
Conversation
…w` in `secrets.rst`.
encukou
approved these changes
May 10, 2024
encukou
left a comment
Member
There was a problem hiding this comment.
These would be best positional-only, but it's much too late for that now. The docs should match the API.
encukou
enabled auto-merge (squash)
May 10, 2024 14:27
Thanks @adamtheturtle for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 10, 2024
…w` in `secrets.rst` (pythonGH-118098) Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst`. (cherry picked from commit c444362) Co-authored-by: Adam Dangoor <adamdangoor@gmail.com>
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 10, 2024
…w` in `secrets.rst` (pythonGH-118098) Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst`. (cherry picked from commit c444362) Co-authored-by: Adam Dangoor <adamdangoor@gmail.com>
GH-118906 is a backport of this pull request to the 3.13 branch. |
GH-118907 is a backport of this pull request to the 3.12 branch. |
encukou pushed a commit
that referenced
this pull request
May 10, 2024
…andbelow` in `secrets.rst` (GH-118098) (GH-118907) Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst` (GH-118098) Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst`. (cherry picked from commit c444362) Co-authored-by: Adam Dangoor <adamdangoor@gmail.com>
encukou pushed a commit
that referenced
this pull request
May 10, 2024
…andbelow` in `secrets.rst` (GH-118098) (GH-118906) Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst` (GH-118098) Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst`. (cherry picked from commit c444362) Co-authored-by: Adam Dangoor <adamdangoor@gmail.com>
estyxx pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…w` in `secrets.rst` (pythonGH-118098) Correct the argument names for `secrets.choice` and `secrets.randbelow` in `secrets.rst`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--118098.org.readthedocs.build/