Skip to content

[gh-117657] Fix some issues with TSAN in typeobject - #118249

Merged
DinoV merged 1 commit into
python:mainfrom
DinoV:nogil_type_tsan
Apr 30, 2024
Merged

[gh-117657] Fix some issues with TSAN in typeobject#118249
DinoV merged 1 commit into
python:mainfrom
DinoV:nogil_type_tsan

Conversation

@DinoV

@DinoVDinoV commented Apr 24, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

The tp_version field is updated under a lock, but it can be read lock-free. The assigns and reads from it need to use relaxed atomics.

@bedevere-appbedevere-appBot mentioned this pull request Apr 24, 2024
Closed
@DinoV
DinoV marked this pull request as ready for review April 24, 2024 23:42
@DinoV
DinoV requested a review from markshannon as a code ownerApril 24, 2024 23:42
@DinoV
DinoV requested review from colesbury and mpageApril 25, 2024 16:19
@DinoV
DinoV merged commit 19d468a into python:mainApr 30, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@DinoV@SonicField
[pythongh-117657] Fix some issues with TSAN in typeobject (python#118249
c4626c1
)
Fix some racing reads in typebobject.c
@DinoV
DinoV deleted the nogil_type_tsan branch May 31, 2024 18:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner
@mpagempageAwaiting requested review from mpage

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DinoV@colesbury