gh-116767: fix crash on 'async with' with many context managers

[iritkatriel]

Fixes#116767.

• Issue: Python/flowgraph.c:701: basicblock *push_except_block(struct _PyCfgExceptStack *, cfg_instr *): Assertion `stack->depth <= CO_MAXBLOCKS' failed #116767

[encukou]

Thank you! I can't say I follow all of what's happening here, but I have a better picture now :)

This is technically backwards incompatible -- the limit is decreased even for plain with (or while, etc.) in a generator or async function. For example, these worked in Python 3.12:

asyncdeft():
withc,c,c,c,c,c,c,c,c,c,c,c,c,c,c,c,c,c,c,c: cdefg():
withc,c,c,c,c,c,c,c,c,c,c,c,c,c,c,c,c,c,c,c: yield

Should CO_MAXBLOCKS be bumped up to 21 to allow this?

[iritkatriel]

Should CO_MAXBLOCKS be bumped up to 21 to allow this?

We could, though this maximum static depth is not documented anywhere and I seriously doubt anyone hits it.

[iritkatriel]

Should CO_MAXBLOCKS be bumped up to 21 to allow this?

We could, though this maximum static depth is not documented anywhere and I seriously doubt anyone hits it.

I made the change, it changes semantics the other way (allowing one more nested level in the non-generator case). I think that's ok. (The compiler could distinguish the cases and use a different limit for each, but I don't think it's worth the added complexity).

[encukou]

Thank you!

I guess the kind of use-case that would hit this is auto-generated code. Bumping to 21 is easier than researching if someone does that.

[miss-islington-app]

Thanks @iritkatriel for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

[miss-islington-app]

Sorry, @iritkatriel and @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c1bf4874c1e9db2beda1d62c8c241229783c789b 3.12

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL 3.x has failed when building commit c1bf487.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1225/builds/2170) and take a look at the build logs.
4. Check if the failure is related to this commit (c1bf487) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1225/builds/2170

Failed tests:

• test_eintr
• test.test_concurrent_futures.test_process_pool

Failed subtests:

• test_flock - main.FNTLEINTRTest.test_flock
• test_map_timeout - test.test_concurrent_futures.test_process_pool.ProcessPoolSpawnProcessPoolExecutorTest.test_map_timeout
• test_all - test.test_eintr.EINTRTests.test_all
• test_lockf - main.FNTLEINTRTest.test_lockf
• test_map_timeout - test.test_concurrent_futures.test_process_pool.ProcessPoolForkserverProcessPoolExecutorTest.test_map_timeout

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line 535, in test_flockself._lock(fcntl.flock, "flock")
~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line 517, in _lockraiseException("failed to sync child in %.1f sec"% dt)
Exception: failed to sync child in 300.0 sec
Traceback (most recent call last):
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_eintr.py", line 17, in test_all
script_helper.run_test_script(script)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/support/script_helper.py", line 316, in run_test_scriptraiseAssertionError(f"{name} failed")
AssertionError: script _test_eintr.py failed
Traceback (most recent call last):
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line 532, in test_lockfself._lock(fcntl.lockf, "lockf")
~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line 517, in _lockraiseException("failed to sync child in %.1f sec"% dt)
Exception: failed to sync child in 300.7 sec
Traceback (most recent call last):
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 71, in test_map_timeoutself.assertEqual([None, None], results)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^AssertionError: Lists differ: [None, None] != []
Traceback (most recent call last):
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line 532, in test_lockfself._lock(fcntl.lockf, "lockf")
~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line 517, in _lockraiseException("failed to sync child in %.1f sec"% dt)
Exception: failed to sync child in 300.0 sec

[bedevere-app]

GH-118477 is a backport of this pull request to the 3.12 branch.