Skip to content

gh-116322: Rename PyModule_ExperimentalSetGIL to PyUnstable_Module_SetGIL - #118645

Merged
encukou merged 1 commit into
python:mainfrom
encukou:experimental_unstable
May 6, 2024
Merged

gh-116322: Rename PyModule_ExperimentalSetGIL to PyUnstable_Module_SetGIL#118645
encukou merged 1 commit into
python:mainfrom
encukou:experimental_unstable

Conversation

@encukou

@encukouencukou commented May 6, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

The PyUnstable prefix has defined semantics and workflow, and generates a note in the docs:

image

📚 Documentation preview 📚: https://cpython-previews--118645.org.readthedocs.build/

@encukou
encukou requested a review from colesburyMay 6, 2024 12:48
@bedevere-appbedevere-appBot mentioned this pull request May 6, 2024
Closed
@encukouencukou mentioned this pull request May 6, 2024
Merged
@colesbury
colesbury requested a review from swtaarrsMay 6, 2024 15:36
colesbury
colesbury approved these changes May 6, 2024
View reviewed changes

@colesburycolesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @swtaarrs

swtaarrs
swtaarrs approved these changes May 6, 2024
View reviewed changes

@swtaarrsswtaarrs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@encukou
encukou merged commit 417dd3a into python:mainMay 6, 2024
@encukou
encukou deleted the experimental_unstable branch May 6, 2024 16:59
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@encukou@SonicField
pythongh-116322: Rename PyModule_ExperimentalSetGIL to PyUnstable_Mod…
7678b39
…ule_SetGIL (pythonGH-118645)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swtaarrsswtaarrsswtaarrs approved these changes
@colesburycolesburycolesbury approved these changes
@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner
@abalkinabalkinAwaiting requested review from abalkin
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou@swtaarrs@colesbury