Uh oh!
There was an error while loading. Please reload this page.
gh-118527: Intern code consts in free-threaded build - #118667
Conversation
We already intern and immortalize most string constants. In the free-threaded build, other constants can be a source of reference count contention because they are shared by all threads running the same code objects.
colesbury
commented
May 6, 2024
!buildbot nogil |
bedevere-bot
commented
May 6, 2024
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 5e8c0f0 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| else if (PyTuple_CheckExact(op)) { | ||
| Py_ssize_t size = PyTuple_GET_SIZE(op); | ||
| PyObject **data = _PyTuple_ITEMS(op); | ||
| return _Py_HashBytes(data, sizeof(PyObject *) * size); |
There was a problem hiding this comment.
We first intern and de-dupe the contents so identity comparisons (including hasing pointers) is sufficient.
For example the following prints True with this PR:
deffoo():
return (0.0, (1, 2, "hello"))
defbar():
return (0.0, (1, 2, "hello"))
print(foo() isbar())
DinoV
left a comment
There was a problem hiding this comment.
Adding the mutex to LOCKS_INIT is really the most important thing, the slices are probably fine either way, it'd just be a little less duplication if we followed them, but they're probably usually in the small ints list anyway.
colesbury
commented
May 6, 2024
!buildbot nogil |
bedevere-bot
commented
May 6, 2024
🤖 New build scheduled with the buildbot fleet by @colesbury for commit f5cab78 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
…8667) We already intern and immortalize most string constants. In the free-threaded build, other constants can be a source of reference count contention because they are shared by all threads running the same code objects.
We already intern and immortalize most string constants. In the free-threaded build, other constants are a frequent source of reference count contention because they are shared by all threads running the same code objects.
For example, the following function would not otherwise scale because
1.5would be a non-immortalized constant shared by all threads that executerun_in_parallel.