Uh oh!
There was an error while loading. Please reload this page.
gh-111495: Add tests for PyTuple C API - #118757
Conversation
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
skirpichev
commented
May 8, 2024
Probably, could skip news:) It's #111606, with some minor fixes and tests for PyTuple_Pack, PyTuple_SetItem/PyTuple_SET_ITEM and PyTuple_Resize. Limited API C functions are moved to _testlimitedcapi/ directory. |
skirpichev
commented
May 9, 2024
@rawwar, let me know if you are not OK with this using your code. |
rawwar
commented
May 9, 2024
Please reuse it. I am completely fine with it. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
* fix reference leak * add assert * revert arguments of tuple_resize()
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
commented
Aug 26, 2024
I merged your PR, thanks @skirpichev! |
skirpichev
commented
Aug 26, 2024
@vstinner, shouldn't this be backported to 3.12 and 3.13? |
bedevere-bot
commented
Aug 26, 2024
|
bedevere-bot
commented
Aug 26, 2024
|
bedevere-bot
commented
Aug 26, 2024
|
bedevere-bot
commented
Aug 26, 2024
|
bedevere-bot
commented
Aug 26, 2024
|
vstinner
commented
Aug 26, 2024
I would prefer to not backport them. @serhiy-storchaka: What's your call on backporting new C API tests to stable branches? |
serhiy-storchaka
commented
Aug 26, 2024
I prefer to backport tests as far as possible. This helps if we change the behavior in new version or backport bug fixes. |
Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @skirpichev and @vstinner, I could not cleanly backport this to |
Sorry, @skirpichev and @vstinner, I could not cleanly backport this to |
bedevere-bot
commented
Aug 26, 2024
|
skirpichev
commented
Aug 27, 2024
I'm working on backports. |
(cherry picked from commit dbc1752) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: kalyanr <kalyan.ben10@live.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
GH-123371 is a backport of this pull request to the 3.13 branch. |
skirpichev
commented
Aug 27, 2024
3.12 is less trivial due to changes from #116417. I can do backport for current state of 3.12, but maybe it does make sense to backport first pr's from above issue? Or 3.12 not worth efforts at all? |
(cherry picked from commit dbc1752) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: kalyanr <kalyan.ben10@live.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
GH-123379 is a backport of this pull request to the 3.12 branch. |
Uh oh!
There was an error while loading. Please reload this page.