Skip to content

Format None, True, False and NotImplemented as literals - #118758

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:docs-none-literal
May 8, 2024
Merged

Format None, True, False and NotImplemented as literals#118758
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:docs-none-literal

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented May 8, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchakaserhiy-storchaka added docs Documentation in the Doc dir skip issue skip news needs backport to 3.12 only security fixes labels May 8, 2024
AlexWaygood
AlexWaygood reviewed May 8, 2024
View reviewed changes
Comment threadMisc/NEWS.d/3.11.0b1.rst Outdated
Comment threadMisc/NEWS.d/3.12.0a1.rst Outdated
Comment threadMisc/NEWS.d/3.13.0a1.rst Outdated
Comment threadMisc/NEWS.d/3.13.0a2.rst Outdated
@rhettinger
rhettinger removed request for a team and rhettingerMay 8, 2024 15:12
JelleZijlstra
JelleZijlstra reviewed May 8, 2024
View reviewed changes
Comment threadDoc/c-api/object.rst Outdated
@serhiy-storchaka@JelleZijlstra@AlexWaygood
Apply suggestions from code review
3cdb8d9
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@serhiy-storchaka
serhiy-storchaka merged commit 05c2fe1 into python:mainMay 8, 2024
@miss-islington-app

miss-islington-appBot commented May 8, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@serhiy-storchaka
serhiy-storchaka deleted the docs-none-literal branch May 8, 2024 19:35
@miss-islington-app

miss-islington-appBot commented May 8, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 05c2fe1acda9ea5a57061642c36e8b73bb4fbba4 3.12

@serhiy-storchakaserhiy-storchaka added the needs backport to 3.13 bugs and security fixes label May 8, 2024
@miss-islington-app

miss-islington-appBot commented May 8, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2024
@serhiy-storchaka@miss-islington
Format None, True, False and NotImplemented as literals (pythonGH-118758
1ee2c7b
)
(cherry picked from commit 05c2fe1)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-appBot commented May 8, 2024

Copy link
Copy Markdown

GH-118792 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 8, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 8, 2024
@serhiy-storchaka
Format None, True, False and NotImplemented as literals (pythonGH-118758
392bd67
)
(cherry picked from commit 05c2fe1)
@bedevere-app

bedevere-appBot commented May 8, 2024

Copy link
Copy Markdown

GH-118794 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label May 8, 2024
serhiy-storchaka added a commit that referenced this pull request May 8, 2024
@miss-islington@serhiy-storchaka
[3.13] Format None, True, False and NotImplemented as literals (GH-11…
8f31af6
…8758) (GH-118792)
(cherry picked from commit 05c2fe1)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request May 8, 2024
@serhiy-storchaka
[3.12] Format None, True, False and NotImplemented as literals (GH-11…
530c3bb
…8758) (GH-118794)
(cherry picked from commit 05c2fe1)
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
@serhiy-storchakaserhiy-storchaka removed their assignment Jul 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments
@AlexWaygoodAlexWaygoodAlexWaygood left review comments
@rhettingerrhettingerrhettinger approved these changes
@barneygalebarneygaleAwaiting requested review from barneygalebarneygale is a code owner
@ericvsmithericvsmithAwaiting requested review from ericvsmithericvsmith is a code owner
@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner
@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner
@brettcannonbrettcannonAwaiting requested review from brettcannon
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrently
@ncoghlanncoghlanAwaiting requested review from ncoghlan
@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner
@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner
@gvanrossumgvanrossumAwaiting requested review from gvanrossum
@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner
@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka@JelleZijlstra@rhettinger@gvanrossum@AlexWaygood