Skip to content

gh-118773: Use language-invariant SDDL string instead of aliases for ACLs. - #118800

Merged
zooba merged 3 commits into
python:mainfrom
zooba:gh-118773
May 9, 2024
Merged

gh-118773: Use language-invariant SDDL string instead of aliases for ACLs.#118800
zooba merged 3 commits into
python:mainfrom
zooba:gh-118773

Conversation

@zooba

@zoobazooba commented May 8, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 8, 2024
Closed
@Eclips4Eclips4 added the needs backport to 3.13 bugs and security fixes label May 8, 2024
@Eclips4Eclips4 mentioned this pull request May 9, 2024
Closed
@zoobazooba changed the title gh-118773: Use well-known constants instead of aliases for ACLs.gh-118773: Use language-invariant SDDL string instead of aliases for ACLs.May 9, 2024
@zooba

zooba commented May 9, 2024

Copy link
Copy Markdown
MemberAuthor

!buildbot .windows.

@bedevere-bot

bedevere-bot commented May 9, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit 99ae180 🤖

The command will test the builders whose names match following regular expression: .*windows.*

The builders matched are:

  • AMD64 Windows11 Non-Debug PR
  • AMD64 Windows11 Refleaks PR
  • AMD64 Windows Server 2022 NoGIL PR
  • ARM64 Windows PR
  • ARM64 Windows Non-Debug PR
  • AMD64 Windows10 PR
  • AMD64 Windows11 Bigmem PR

@zooba

zooba commented May 9, 2024

Copy link
Copy Markdown
MemberAuthor

FYI, this will be backported to all branches, but because the original change hasn't been merged into those yet it can't be done automatically. I'll handle it myself once this one is reviewed and merged.

@zooba

zooba commented May 9, 2024

Copy link
Copy Markdown
MemberAuthor

The test_cext failure on ARM64 is unrelated.

eryksun
eryksun reviewed May 9, 2024
View reviewed changes
Comment threadModules/posixmodule.c Outdated
eryksun
eryksun reviewed May 9, 2024
View reviewed changes
Comment threadModules/posixmodule.c Outdated
@zooba
zooba merged commit 8af84b5 into python:mainMay 9, 2024
@miss-islington-app

miss-islington-appBot commented May 9, 2024

Copy link
Copy Markdown

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@zooba
zooba deleted the gh-118773 branch May 9, 2024 16:43
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@zooba@miss-islington
pythongh-118773: Use language-invariant SDDL string instead of aliase…
571459f
…s for ACLs. (pythonGH-118800)
(cherry picked from commit 8af84b5)
Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app

bedevere-appBot commented May 9, 2024

Copy link
Copy Markdown

GH-118858 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 9, 2024
zooba added a commit that referenced this pull request May 9, 2024
@miss-islington@zooba
gh-118773: Use language-invariant SDDL string instead of aliases for …
9d646d0
…ACLs. (GH-118800)
(cherry picked from commit 8af84b5)
Co-authored-by: Steve Dower <steve.dower@python.org>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@zooba@SonicField
pythongh-118773: Use language-invariant SDDL string instead of aliase…
a6bc4e3
…s for ACLs. (pythonGH-118800)
@arhadthedevarhadthedev mentioned this pull request May 12, 2024
Open
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eryksuneryksuneryksun left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zooba@bedevere-bot@eryksun@Eclips4