Skip to content

gh-118810: Allow the JSON encoder to optionally support decimal.Decimal objects - #118811

Closed
kris-the-meowvellous wants to merge 4 commits into
python:mainfrom
kris-the-meowvellous:json_with_decimal
Closed

gh-118810: Allow the JSON encoder to optionally support decimal.Decimal objects#118811
kris-the-meowvellous wants to merge 4 commits into
python:mainfrom
kris-the-meowvellous:json_with_decimal

Conversation

@kris-the-meowvellous

@kris-the-meowvellouskris-the-meowvellous commented May 9, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown

My attempt at implementing what is described in #118810.
My first attempt at contributing to open source, so feedback is appreciated :)

@ghost

ghost commented May 9, 2024•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

bedevere-appBot commented May 9, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-appbedevere-appBot mentioned this pull request May 9, 2024
Closed
@bedevere-app

bedevere-appBot commented May 9, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@kris-the-meowvellous

kris-the-meowvellous commented May 9, 2024

Copy link
Copy Markdown
Author

Apologies, I don't know how merge conflicts work and I thought that would fix it.

@savannahostrowski

savannahostrowski commented May 9, 2024

Copy link
Copy Markdown
Member

Hey - thanks for the PR! I think @ezio-melotti and @rhettinger would be good reviewers for this change in json.

@kris-the-meowvellous
kris-the-meowvellous deleted the json_with_decimal branch May 10, 2024 13:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kris-the-meowvellous@savannahostrowski