Skip to content

gh-118824: Remove deprecated master_open and slave_open from pty - #118826

Merged
sobolevn merged 5 commits into
python:mainfrom
sobolevn:issue-118824
May 28, 2024
Merged

gh-118824: Remove deprecated master_open and slave_open from pty#118826
sobolevn merged 5 commits into
python:mainfrom
sobolevn:issue-118824

Conversation

@sobolevn

@sobolevnsobolevn commented May 9, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@sobolevn
sobolevn requested a review from gpsheadMay 9, 2024 08:52
@bedevere-appbedevere-appBot mentioned this pull request May 9, 2024
Closed
ronaldoussoren
ronaldoussoren reviewed May 9, 2024
View reviewed changes
Comment threadLib/pty.py
hugovk
hugovk reviewed May 9, 2024
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
hugovk
hugovk reviewed May 26, 2024
View reviewed changes
Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadMisc/NEWS.d/next/Library/2024-05-09-11-50-26.gh-issue-118824.-jBJQC.rst Outdated
sobolevnand others added 2 commits May 28, 2024 13:52
@sobolevn@hugovk
Apply suggestions from code review
c73b325
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@sobolevn
Merge branch 'main' into issue-118824
7079349
hugovk
hugovk approved these changes May 28, 2024
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@sobolevn
sobolevn merged commit f912e5a into python:mainMay 28, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn@hugovk@estyxx
pythongh-118824: Remove deprecatedmaster_openandslave_openfro…
9fe427c
…m `pty` (python#118826)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ambv
ambv reviewed Sep 24, 2024
View reviewed changes
Comment threadLib/pty.py
except ImportError:
return master_fd, slave_fd
try:
ioctl(result, I_PUSH, "ptem")

@ambvambvSep 24, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result is a NameError now.

@sobolevnsobolevnSep 24, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #124406

@sobolevnsobolevn mentioned this pull request Sep 24, 2024
Closed
@hauntsaninjahauntsaninja mentioned this pull request Sep 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambvambvambv left review comments
@ronaldoussorenronaldoussorenronaldoussoren left review comments
@hugovkhugovkhugovk approved these changes
@gpsheadgpsheadAwaiting requested review from gpshead

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@ambv@ronaldoussoren@hugovk