Skip to content

gh-118849: Fix "code will never be executed" warning in dictobject.c - #118850

Merged
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-118849
May 9, 2024
Merged

gh-118849: Fix "code will never be executed" warning in dictobject.c#118850
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-118849

Conversation

@sobolevn

@sobolevnsobolevn commented May 9, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@sobolevnsobolevn added skip news needs backport to 3.13 bugs and security fixes labels May 9, 2024
@sobolevn
sobolevn requested a review from colesburyMay 9, 2024 15:31
@bedevere-appbedevere-appBot mentioned this pull request May 9, 2024
Closed
colesbury
colesbury reviewed May 9, 2024
View reviewed changes
Comment threadObjects/dictobject.c Outdated
@sobolevn
sobolevn merged commit 82abe75 into python:mainMay 9, 2024
@miss-islington-app

miss-islington-appBot commented May 9, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@sobolevn@miss-islington
pythongh-118849: Fix "code will never be executed" warning in `dictob…
9b2ac2e
…ject.c` (pythonGH-118850)
(cherry picked from commit 82abe75)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app

bedevere-appBot commented May 9, 2024

Copy link
Copy Markdown

GH-118859 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 9, 2024
@sobolevn

sobolevn commented May 9, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks for the good catch and for the review! :)

sobolevn added a commit that referenced this pull request May 9, 2024
@miss-islington@sobolevn
[3.13]gh-118849: Fix "code will never be executed" warning in `dicto…
098eec9
…bject.c` (GH-118850) (#118859)
gh-118849: Fix "code will never be executed" warning in `dictobject.c` (GH-118850)
(cherry picked from commit 82abe75)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@sobolevn@SonicField
pythongh-118849: Fix "code will never be executed" warning in `dictob…
63af4b5
…ject.c` (python#118850)
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes
@methanemethaneAwaiting requested review from methanemethane is a code owner
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn@colesbury