Uh oh!
There was an error while loading. Please reload this page.
gh-118846: Fix free-threading test failures when run sequentially - #118864
Conversation
The free-threaded build currently immortalizes some objects once the first thread is started. This can lead to test failures depending on the order in which tests are run. This PR addresses those failures by suppressing immortalization or skipping the affected tests.
colesbury
commented
May 9, 2024
I still have: Not sure if the pydoc thing is related, but the gc might. |
colesbury
commented
May 9, 2024
The pydoc failure is a funny interaction between tests. In cpython/Lib/test/test_inspect/test_inspect.py Lines 771 to 775 in 98ff3f6 In the free-threaded build, this class is now immortalized so it's still alive later on when |
colesbury
commented
May 10, 2024
Ok, I think the |
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ly (pythonGH-118864) The free-threaded build currently immortalizes some objects once the first thread is started. This can lead to test failures depending on the order in which tests are run. This PR addresses those failures by suppressing immortalization or skipping the affected tests. (cherry picked from commit b309c8e) Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-118927 is a backport of this pull request to the 3.13 branch. |
…lly (GH-118864) (#118927) The free-threaded build currently immortalizes some objects once the first thread is started. This can lead to test failures depending on the order in which tests are run. This PR addresses those failures by suppressing immortalization or skipping the affected tests. (cherry picked from commit b309c8e) Co-authored-by: Sam Gross <colesbury@gmail.com>
hroncok
commented
May 10, 2024
This is the only one I got now: |
colesbury
commented
May 10, 2024
Just checking, this is from |
AlexWaygood
commented
May 10, 2024
Note that that AST test was only merged (and backported to 3.13) yesterday in #118854 |
hroncok
commented
May 11, 2024
I might have git pulled but forgot to rebuild it. Mea culpa. Trying fresh. |
hroncok
commented
May 11, 2024
All is good now, thank you! |
…ly (python#118864) The free-threaded build currently immortalizes some objects once the first thread is started. This can lead to test failures depending on the order in which tests are run. This PR addresses those failures by suppressing immortalization or skipping the affected tests.
The free-threaded build currently immortalizes some objects once the first thread is started. This can lead to test failures depending on the order in which tests are run. This PR addresses those failures by suppressing immortalization or skipping the affected tests.