Skip to content

gh-119185: Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager - #118881

Merged
JelleZijlstra merged 4 commits into
python:mainfrom
Sachaa-Thanasius:patch-1
May 20, 2024
Merged

gh-119185: Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager#118881
JelleZijlstra merged 4 commits into
python:mainfrom
Sachaa-Thanasius:patch-1

Conversation

@Sachaa-Thanasius

@Sachaa-ThanasiusSachaa-Thanasius commented May 10, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

The function name has an underscore. Without this, calling help can cause an exception.

Should be reproducible by calling help() in the repl on Windows. I personally found it by calling it on sysconfig.get_config_var.

Doesn’t seem worthy of a news entry.

@ghost

ghost commented May 10, 2024•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

bedevere-appBot commented May 10, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-appBot commented May 10, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-appBot commented May 13, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Eclips4Eclips4 mentioned this pull request May 19, 2024
Closed
@Eclips4Eclips4 changed the title Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pagergh-119185: Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pagerMay 19, 2024
@Eclips4Eclips4 added the needs backport to 3.13 bugs and security fixes label May 19, 2024
@Eclips4
Eclips4 requested a review from pablogsalMay 19, 2024 20:51
@JelleZijlstra
JelleZijlstra merged commit 05e1dce into python:mainMay 20, 2024
@miss-islington-app

miss-islington-appBot commented May 20, 2024

Copy link
Copy Markdown

Thanks @Sachaa-Thanasius for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
@Sachaa-Thanasius@miss-islington
pythongh-119185: Fix typo in_pyrepl.pager:tempfilepagershould …
3f0adf5
…be `tempfile_pager` (pythonGH-118881)
Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`
The name with no underscore doesn't exist.
(cherry picked from commit 05e1dce)
Co-authored-by: Thanos <111999343+Sachaa-Thanasius@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented May 20, 2024

Copy link
Copy Markdown

GH-119211 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 20, 2024
@Sachaa-Thanasius
Sachaa-Thanasius deleted the patch-1 branch May 20, 2024 14:54
@Sachaa-Thanasius
Sachaa-Thanasius restored the patch-1 branch May 20, 2024 14:55
@Sachaa-Thanasius
Sachaa-Thanasius deleted the patch-1 branch May 20, 2024 14:55
JelleZijlstra pushed a commit that referenced this pull request May 20, 2024
@miss-islington@Sachaa-Thanasius
[3.13]gh-119185: Fix typo in_pyrepl.pager:tempfilepagershould…
a52ed7e
… be `tempfile_pager` (GH-118881) (#119211)
Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`
The name with no underscore doesn't exist.
(cherry picked from commit 05e1dce)
Co-authored-by: Thanos <111999343+Sachaa-Thanasius@users.noreply.github.com>
@ambvambv added the topic-repl Related to the interactive shell label May 23, 2024
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
@Eclips4Eclips4 mentioned this pull request Jun 8, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Sachaa-Thanasius@estyxx
pythongh-119185: Fix typo in_pyrepl.pager:tempfilepagershould …
b5f66ed
…be `tempfile_pager` (python#118881)
Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`
The name with no underscore doesn't exist.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4Eclips4Eclips4 approved these changes
@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

Assignees

No one assigned

Labels

skip newstopic-replRelated to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sachaa-Thanasius@Eclips4@ambv@JelleZijlstra