Skip to content

gh-118895: Call PyType_Ready() on typing.NoDefault - #118897

Merged
JelleZijlstra merged 3 commits into
python:mainfrom
JelleZijlstra:readydefault
May 10, 2024
Merged

gh-118895: Call PyType_Ready() on typing.NoDefault#118897
JelleZijlstra merged 3 commits into
python:mainfrom
JelleZijlstra:readydefault

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented May 10, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 10, 2024
Closed
@AlexWaygoodAlexWaygood added the needs backport to 3.13 bugs and security fixes label May 10, 2024
sobolevn
sobolevn approved these changes May 10, 2024
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also solves multiple other issues, like:

>>>fromtypingimportNoDefault>>>NoDefault.__class__Traceback (mostrecentcalllast):
File"<python-input-1>", line1, in<module>NoDefault.__class__AttributeError: 'NoDefaultType'objecthasnoattribute'__class__'. Didyoumean: '__hash__'?

Thanks!

@JelleZijlstraJelleZijlstra mentioned this pull request May 10, 2024
Merged
sobolevn
sobolevn reviewed May 10, 2024
View reviewed changes
Comment threadLib/test/test_typing.py
sobolevn
sobolevn reviewed May 10, 2024
View reviewed changes
Comment threadLib/test/test_typing.py
@sobolevnsobolevn mentioned this pull request May 10, 2024
Merged
@JelleZijlstra
JelleZijlstra merged commit 13d7cf9 into python:mainMay 10, 2024
@miss-islington-app

miss-islington-appBot commented May 10, 2024

Copy link
Copy Markdown

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@JelleZijlstra
JelleZijlstra deleted the readydefault branch May 10, 2024 15:42
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2024
@JelleZijlstra@miss-islington
pythongh-118895: Call PyType_Ready() on typing.NoDefault (pythonGH-11…
2bdfa85
…8897)
(cherry picked from commit 13d7cf9)
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app

bedevere-appBot commented May 10, 2024

Copy link
Copy Markdown

GH-118914 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 10, 2024
JelleZijlstra added a commit that referenced this pull request May 10, 2024
@miss-islington@JelleZijlstra
[3.13]gh-118895: Call PyType_Ready() on typing.NoDefault (GH-118897) (…
6df4913
…#118914)
(cherry picked from commit 13d7cf9)
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@JelleZijlstra@estyxx
pythongh-118895: Call PyType_Ready() on typing.NoDefault (python#118897)
1d362c3
@ZeroIntensityZeroIntensity mentioned this pull request Aug 29, 2024
Closed
@JelleZijlstra
JelleZijlstra restored the readydefault branch September 10, 2024 23:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JelleZijlstra@sobolevn@AlexWaygood