Skip to content

gh-118836: Fix JIT build error when SHT_NOTE section is present - #119000

Merged
brandtbucher merged 1 commit into
python:mainfrom
mgorny:jit-sht_note
May 13, 2024
Merged

gh-118836: Fix JIT build error when SHT_NOTE section is present#119000
brandtbucher merged 1 commit into
python:mainfrom
mgorny:jit-sht_note

Conversation

@mgorny

@mgornymgorny commented May 13, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Fix an AssertionError when building with --enable-experimental-jit and the compiler emits a SHT_NOTE section.

@mgorny
mgorny requested a review from brandtbucher as a code ownerMay 13, 2024 13:59
@bedevere-appbedevere-appBot mentioned this pull request May 13, 2024
Closed
@brandtbucherbrandtbucher self-assigned this May 13, 2024
@brandtbucherbrandtbucher added type-bug An unexpected behavior, bug, or error build The build process and cross-build needs backport to 3.13 bugs and security fixes labels May 13, 2024
brandtbucher
brandtbucher approved these changes May 13, 2024
View reviewed changes

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@brandtbucher
brandtbucher merged commit e04cd96 into python:mainMay 13, 2024
@miss-islington-app

miss-islington-appBot commented May 13, 2024

Copy link
Copy Markdown

Thanks @mgorny for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
@mgorny@miss-islington
pythonGH-118836: Fix JIT build error when SHT_NOTE section is present (…
e257f51
…pythonGH-119000)
(cherry picked from commit e04cd96)
Co-authored-by: Michał Górny <mgorny@gentoo.org>
@bedevere-app

bedevere-appBot commented May 13, 2024

Copy link
Copy Markdown

GH-119020 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 13, 2024
@mgorny

mgorny commented May 14, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks!

@mgorny
mgorny deleted the jit-sht_note branch May 14, 2024 04:54
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@mgorny@estyxx
pythonGH-118836: Fix JIT build error when SHT_NOTE section is present (…
2743976
…pythonGH-119000)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher approved these changes

Assignees

@brandtbucherbrandtbucher

Labels

buildThe build process and cross-buildtopic-JITtype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgorny@brandtbucher