Skip to content

Docs: Add central references to free-threading-related options - #119017

Merged
colesbury merged 3 commits into
python:mainfrom
swtaarrs:cpython-docs
May 21, 2024
Merged

Docs: Add central references to free-threading-related options#119017
colesbury merged 3 commits into
python:mainfrom
swtaarrs:cpython-docs

Conversation

@swtaarrs

@swtaarrsswtaarrs commented May 13, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

The docs for Py_mod_gil said "See PYTHON_GIL and -X gil <-X> for more detail," but neither of those gave any detail about loading extensions in a free-threaded build.

  • Replace that sentence with a reference to the summary in the 3.13 what's new doc.
  • Add a few more links to that summary in other related areas.
  • Fix a syntax error in the versionadded:: line for Py_mod_gil that was causing it to not get rendered.

📚 Documentation preview 📚: https://cpython-previews--119017.org.readthedocs.build/

@swtaarrs
swtaarrs requested review from colesbury and mpageMay 13, 2024 21:00
@swtaarrsswtaarrs changed the title Add central references to free-threading-related optionsDocs: Add central references to free-threading-related optionsMay 13, 2024
swtaarrs
swtaarrs commented May 13, 2024
View reviewed changes
Comment threadDoc/using/configure.rst Outdated
@colesbury
colesbury merged commit 9fa206a into python:mainMay 21, 2024
@miss-islington-app

miss-islington-appBot commented May 21, 2024

Copy link
Copy Markdown

Thanks @swtaarrs for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
@swtaarrs@miss-islington
Docs: Add central references to free-threading-related options (pytho…
0cb67d4
…nGH-119017)
(cherry picked from commit 9fa206a)
Co-authored-by: Brett Simmers <swtaarrs@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented May 21, 2024

Copy link
Copy Markdown

GH-119367 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 21, 2024
colesbury pushed a commit that referenced this pull request May 21, 2024
@miss-islington@swtaarrs
[3.13] Docs: Add central references to free-threading-related options (…
0582016
…GH-119017) (#119367)
Docs: Add central references to free-threading-related options (GH-119017)
(cherry picked from commit 9fa206a)
Co-authored-by: Brett Simmers <swtaarrs@users.noreply.github.com>
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@swtaarrs@estyxx
Docs: Add central references to free-threading-related options (pytho…
d7a1718
…n#119017)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes
@mpagempageAwaiting requested review from mpage
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner
@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip issueskip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swtaarrs@colesbury