Uh oh!
There was an error while loading. Please reload this page.
GH-73991: Add pathlib.Path.copy() - #119058
Merged
Merged
Conversation
Add a `Path.copy()` method that copies a file to a target file or directory using `shutil.copy2()`. In the private pathlib ABCs, we add a version that supports copying from one instance of `PathBase` to another. We don't copy metadata, because doing so probably requires new APIs that haven't been designed yet.
pathlib.Path.copy() method.pathlib.Path.copy()barneygale
commented
May 27, 2024
ContributorAuthor
Marking this PR as a draft, because I think we'll need to introduce |
barneygale
marked this pull request as draft
May 27, 2024 14:40
barneygale
marked this pull request as ready for review
June 3, 2024 06:42
zooba
reviewed
Jun 4, 2024
zooba
left a comment
Member
There was a problem hiding this comment.
Just some thoughts, nothing I'd necessarily block the PR on. I like the way it looks overall!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
eryksun
reviewed
Jun 5, 2024
Uh oh!
There was an error while loading. Please reload this page.
eryksun
reviewed
Jun 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
eryksun
reviewed
Jun 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
eryksun
reviewed
Jun 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
zooba
reviewed
Jun 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Eryk Sun <eryksun@gmail.com>
zooba
commented
Jun 12, 2024
Member
Looks fine to me, but I only quickly reskimmed it. I'll be away for the next few days, so don't wait for me if you guys think it's ready. |
mrahtz pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
Add a `Path.copy()` method that copies the content of one file to another. This method is similar to `shutil.copyfile()` but differs in the following ways: - Uses `fcntl.FICLONE` where available (see pythonGH-81338) - Uses `os.copy_file_range` where available (see pythonGH-81340) - Uses `_winapi.CopyFile2` where available, even though this copies more metadata than the other implementations. This makes `WindowsPath.copy()` more similar to `shutil.copy2()`. The method is presently _less_ specified than the `shutil` functions to allow OS-specific optimizations that might copy more or less metadata. Incorporates code from pythonGH-81338 and pythonGH-93152. Co-authored-by: Eryk Sun <eryksun@gmail.com>
noahbkim pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Add a `Path.copy()` method that copies the content of one file to another. This method is similar to `shutil.copyfile()` but differs in the following ways: - Uses `fcntl.FICLONE` where available (see pythonGH-81338) - Uses `os.copy_file_range` where available (see pythonGH-81340) - Uses `_winapi.CopyFile2` where available, even though this copies more metadata than the other implementations. This makes `WindowsPath.copy()` more similar to `shutil.copy2()`. The method is presently _less_ specified than the `shutil` functions to allow OS-specific optimizations that might copy more or less metadata. Incorporates code from pythonGH-81338 and pythonGH-93152. Co-authored-by: Eryk Sun <eryksun@gmail.com>
estyxx pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Add a `Path.copy()` method that copies the content of one file to another. This method is similar to `shutil.copyfile()` but differs in the following ways: - Uses `fcntl.FICLONE` where available (see pythonGH-81338) - Uses `os.copy_file_range` where available (see pythonGH-81340) - Uses `_winapi.CopyFile2` where available, even though this copies more metadata than the other implementations. This makes `WindowsPath.copy()` more similar to `shutil.copy2()`. The method is presently _less_ specified than the `shutil` functions to allow OS-specific optimizations that might copy more or less metadata. Incorporates code from pythonGH-81338 and pythonGH-93152. Co-authored-by: Eryk Sun <eryksun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
Path.copy()method that copies the content of one file to another.This method is similar to
shutil.copyfile()but differs in the following ways:fcntl.FICLONEwhere available (see shutil: add reflink=False to file copy functions to control clone/CoW copies (use copy_file_range) #81338)os.copy_file_rangewhere available (see Use copy_file_range() in shutil.copyfile() (server-side copy) #81340)_winapi.CopyFile2where available, even though this copies more metadata than the other implementations. This makesWindowsPath.copy()more similar toshutil.copy2().The method is deliberately less specified than the
shutilfunctions to allow OS-specific optimizations that might copy more or less metadata.Incorporates code by @illia-v and @giampaolo from #81338 and #93152 respectively.
📚 Documentation preview 📚: https://cpython-previews--119058.org.readthedocs.build/