Skip to content

GH-73991: Add pathlib.Path.rmtree() - #119060

Merged
barneygale merged 23 commits into
python:mainfrom
barneygale:gh-73991-rmtree
Jul 20, 2024
Merged

GH-73991: Add pathlib.Path.rmtree()#119060
barneygale merged 23 commits into
python:mainfrom
barneygale:gh-73991-rmtree

Conversation

@barneygale

@barneygalebarneygale commented May 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Add a Path.rmtree() method that removes an entire directory tree, like shutil.rmtree(). The signature of the optional on_error argument matches the Path.walk() argument of the same name, but differs from the onexc and onerror arguments to shutil.rmtree(). Consistency within pathlib is probably more important.

In the private pathlib ABCs, we add an implementation based on walk().

📚 Documentation preview 📚: https://cpython-previews--119060.org.readthedocs.build/

@barneygale
pythonGH-73991: Addpathlib.Path.rmtree()
bbcb1ce
Add a `Path.rmtree()` method that removes an entire directory tree using
`shutil.rmtree()`. The signature of the optional *on_error* argument
matches the `Path.walk()` argument of the same name, but differs from the
*onexc* and *onerror* arguments to `shutil.rmtree()`. Consistency within
pathlib is probably more important.
In the private pathlib ABCs, we add an implementation based on `walk()`.
@bedevere-appbedevere-appBot mentioned this pull request May 15, 2024
Closed
@barneygale
barneygale marked this pull request as draft June 14, 2024 20:09
@barneygale
barneygale marked this pull request as ready for review June 19, 2024 00:42
@barneygale
barneygale requested a review from zoobaJuly 3, 2024 03:55
picnixz
picnixz reviewed Jul 3, 2024
View reviewed changes

@picnixzpicnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that addition by the way. Here are some nitpicking comments.

Comment threadDoc/library/pathlib.rst Outdated
Comment threadDoc/library/pathlib.rst Outdated
Comment threadDoc/library/pathlib.rst Outdated
Comment threadDoc/library/pathlib.rst Outdated
Comment threadDoc/library/pathlib.rst Outdated
Comment threadDoc/whatsnew/3.14.rst Outdated
Comment threadDoc/library/pathlib.rst Outdated
Comment threadLib/pathlib/_abc.py
Comment threadLib/pathlib/_abc.py Outdated
Comment threadLib/pathlib/_abc.py
barneygaleand others added 2 commits July 4, 2024 19:33
@barneygale@picnixz
Apply suggestions from code review
4bcc143
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@barneygale
Address review feedback.
ab0f447
@barneygale
barneygale enabled auto-merge (squash) July 20, 2024 17:48
@AA-Turner

AA-Turner commented Jul 20, 2024

Copy link
Copy Markdown
Member

Docs failure is #122068

@barneygale
barneygale merged commit 094375b into python:mainJul 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments
@zoobazoobaAwaiting requested review from zooba

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@barneygale@AA-Turner@picnixz