Skip to content

gh-119132: Log sys._is_gil_disabled() in test.pythoninfo - #119140

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:pythoninfo
May 18, 2024
Merged

gh-119132: Log sys._is_gil_disabled() in test.pythoninfo#119140
vstinner merged 2 commits into
python:mainfrom
vstinner:pythoninfo

Conversation

@vstinner

@vstinnervstinner commented May 18, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 18, 2024
Closed
@vstinner

vstinner commented May 18, 2024

Copy link
Copy Markdown
MemberAuthor

cc @corona10

corona10
corona10 approved these changes May 18, 2024
View reviewed changes

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vstinner

vstinner commented May 18, 2024

Copy link
Copy Markdown
MemberAuthor

Example on "Tests / Windows (free-threading) / build and test (x64) (pull_request)":

sys._is_gil_enabled: False

It works as expected.

@vstinner
vstinner merged commit 74072a3 into python:mainMay 18, 2024
@vstinner
vstinner deleted the pythoninfo branch May 18, 2024 13:24
@miss-islington-app

miss-islington-appBot commented May 18, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2024
@vstinner@miss-islington
pythongh-119132: Log sys._is_gil_enabled() in test.pythoninfo (python…
b450d53
…GH-119140)
(cherry picked from commit 74072a3)
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-appBot commented May 18, 2024

Copy link
Copy Markdown

GH-119143 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 18, 2024
@vstinner

vstinner commented May 18, 2024

Copy link
Copy Markdown
MemberAuthor

Merged, thanks for reviews.

vstinner added a commit that referenced this pull request May 18, 2024
@miss-islington@vstinner
[3.13]gh-119132: Log sys._is_gil_enabled() in test.pythoninfo (GH-11…
9c2de86
…9140) (#119143)
gh-119132: Log sys._is_gil_enabled() in test.pythoninfo (GH-119140)
(cherry picked from commit 74072a3)
Co-authored-by: Victor Stinner <vstinner@python.org>
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner@estyxx
pythongh-119132: Log sys._is_gil_enabled() in test.pythoninfo (python…
36f43a7
…#119140)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10corona10 approved these changes
@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@corona10@erlend-aasland