Skip to content

GH-118447: Fix FreeBSD test failures. - #119170

Merged
barneygale merged 1 commit into
python:mainfrom
barneygale:gh-118447-freebsd-tests
May 19, 2024
Merged

GH-118447: Fix FreeBSD test failures.#119170
barneygale merged 1 commit into
python:mainfrom
barneygale:gh-118447-freebsd-tests

Conversation

@barneygale

@barneygalebarneygale commented May 19, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Follow-up to #118489. Apparently only macOS requires read permission to call readlink() on a symlink.

@barneygale
pythonGH-118447: Fix FreeBSD test failures.
f7bf985
Apparently only macOS requires read permission to call `readlink()` on a
symlink.
@barneygalebarneygale added the needs backport to 3.13 bugs and security fixes label May 19, 2024
@bedevere-appbedevere-appBot added tests Tests in the Lib/test dir awaiting core review labels May 19, 2024
@bedevere-appbedevere-appBot mentioned this pull request May 19, 2024
Closed
@barneygale
barneygale merged commit 4b76671 into python:mainMay 19, 2024
@miss-islington-app

miss-islington-appBot commented May 19, 2024

Copy link
Copy Markdown

Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2024
@barneygale@miss-islington
pythonGH-118447: Fix FreeBSD test failures. (pythonGH-119170)
eddddec
Apparently only macOS requires read permission to call `readlink()` on a
symlink.
(cherry picked from commit 4b76671)
Co-authored-by: Barney Gale <barney.gale@gmail.com>
@bedevere-app

bedevere-appBot commented May 19, 2024

Copy link
Copy Markdown

GH-119181 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 19, 2024
barneygale added a commit that referenced this pull request May 19, 2024
@miss-islington@barneygale
[3.13]GH-118447: Fix FreeBSD test failures. (GH-119170) (#119181)
fdc50ba
GH-118447: Fix FreeBSD test failures. (GH-119170)
Apparently only macOS requires read permission to call `readlink()` on a
symlink.
(cherry picked from commit 4b76671)
Co-authored-by: Barney Gale <barney.gale@gmail.com>
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@barneygale@estyxx
pythonGH-118447: Fix FreeBSD test failures. (python#119170)
cb12128
Apparently only macOS requires read permission to call `readlink()` on a
symlink.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@barneygale