Skip to content

gh-119174: Fix high DPI causes turtledemo(turtle-graphics examples) windows blurry - #119175

Merged
terryjreedy merged 7 commits into
python:mainfrom
Wulian233:main
May 21, 2024
Merged

gh-119174: Fix high DPI causes turtledemo(turtle-graphics examples) windows blurry#119175
terryjreedy merged 7 commits into
python:mainfrom
Wulian233:main

Conversation

@Wulian233

@Wulian233Wulian233 commented May 19, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Copy https://github.com/python/cpython/blob/main/Lib/idlelib/pyshell.py#L16-L22 to https://github.com/python/cpython/blob/main/Lib/turtledemo/__main__.py

ifwin32:
try:
importctypesPROCESS_SYSTEM_DPI_AWARE=1# Int required.ctypes.OleDLL('shcore').SetProcessDpiAwareness(PROCESS_SYSTEM_DPI_AWARE)
except (ImportError, AttributeError, OSError):
pass

@ghost

ghost commented May 19, 2024•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@Wulian233Wulian233 changed the title Fix high DPI causes turtledemo(turtle-graphics examples) windows blurrygh-119174: Fix high DPI causes turtledemo(turtle-graphics examples) windows blurryMay 19, 2024
@bedevere-appbedevere-appBot mentioned this pull request May 19, 2024
Closed
nineteendo
nineteendo reviewed May 19, 2024
View reviewed changes
Comment threadLib/turtledemo/__main__.py
@Wulian233@nineteendo
Update Lib/turtledemo/__main__.py
f343585
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
terryjreedy
terryjreedy reviewed May 19, 2024
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2024-05-19-18-49-04.gh-issue-119174.5GTv7d.rst Outdated
@terryjreedy

terryjreedy commented May 19, 2024

Copy link
Copy Markdown
Member

Lint failed because news item needed newline. I should have replaced default "Update ..." message as change is not visible in diffs.

I will make unrelated config.py correction in a separate PR.

I will change this to move fixup code to a new function in idlelib.util and then conditionally import and call function.

@terryjreedy

terryjreedy commented May 20, 2024

Copy link
Copy Markdown
Member

Wait for now.

terryjreedy
terryjreedy requested changes May 20, 2024
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2024-05-19-18-49-04.gh-issue-119174.5GTv7d.rst Outdated
@pythonpython deleted a comment from bedevere-appBotMay 20, 2024
@terryjreedyterryjreedy added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 20, 2024
@terryjreedy

terryjreedy commented May 20, 2024

Copy link
Copy Markdown
Member

Ignore change request; I made all changes I think are needed. After separate config patch, I had to fix merge conflict and decided to make additional change here. Please pull changes to your system and test that revised code works.

@Wulian233

Wulian233 commented May 20, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks! Look Good To Me! 😀

@terryjreedy
terryjreedy merged commit 538ed5e into python:mainMay 21, 2024
@miss-islington-app

miss-islington-appBot commented May 21, 2024

Copy link
Copy Markdown

Thanks @Wulian233 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
@Wulian233@miss-islington
pythongh-119174: Fix high DPI causes turtledemo(turtle-graphics examp…
2883195
…les) windows blurry (pythonGH-119175)
------
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 538ed5e)
Co-authored-by: Wulian233 <71213467+Wulian233@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
@Wulian233@miss-islington
pythongh-119174: Fix high DPI causes turtledemo(turtle-graphics examp…
4ac652a
…les) windows blurry (pythonGH-119175)
------
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 538ed5e)
Co-authored-by: Wulian233 <71213467+Wulian233@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented May 21, 2024

Copy link
Copy Markdown

GH-119289 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 21, 2024
@bedevere-app

bedevere-appBot commented May 21, 2024

Copy link
Copy Markdown

GH-119290 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label May 21, 2024
terryjreedy pushed a commit that referenced this pull request May 21, 2024
@miss-islington@Wulian233
[3.13]gh-119174: Fix high DPI causes turtledemo(turtle-graphics exam…
f7303cd
…ples) windows blurry (GH-119175) (#119289)
gh-119174: Fix high DPI causes turtledemo(turtle-graphics examples) windows blurry (GH-119175)
------
(cherry picked from commit 538ed5e)
Co-authored-by: Wulian233 <71213467+Wulian233@users.noreply.github.com>
terryjreedy pushed a commit that referenced this pull request May 21, 2024
@miss-islington@Wulian233
[3.12]gh-119174: Fix high DPI causes turtledemo(turtle-graphics exam…
8b6175c
…ples) windows blurry (GH-119175) (#119290)
gh-119174: Fix high DPI causes turtledemo(turtle-graphics examples) windows blurry (GH-119175)
------
(cherry picked from commit 538ed5e)
Co-authored-by: Wulian233 <71213467+Wulian233@users.noreply.github.com>
@Wulian233Wulian233 mentioned this pull request May 23, 2024
Closed
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
@Wulian233Wulian233 mentioned this pull request Jun 1, 2024
Open
@Wulian233Wulian233 mentioned this pull request Jun 23, 2024
Open
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Wulian233@terryjreedy@estyxx
pythongh-119174: Fix high DPI causes turtledemo(turtle-graphics examp…
d4ce5a3
…les) windows blurry (python#119175)
------
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@Wulian233Wulian233 mentioned this pull request Oct 27, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedyterryjreedyterryjreedy approved these changes
+1 more reviewer
@nineteendonineteendonineteendo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Wulian233@terryjreedy@nineteendo