Uh oh!
There was an error while loading. Please reload this page.
gh-111997: Fix argument count for LINE event and clarify type of argument counts. - #119179
Merged
Merged
Conversation
scoder
commented
May 25, 2024
ContributorAuthor
@iritkatriel@markshannon CI passes, ready for review. |
iritkatriel
approved these changes
May 26, 2024
Thanks @scoder for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2024
…f argument counts. (pythonGH-119179) (cherry picked from commit 70b07aa) Co-authored-by: scoder <stefan_ml@behnel.de>
GH-119575 is a backport of this pull request to the 3.13 branch. |
scoder added a commit
that referenced
this pull request
May 26, 2024
estyxx pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the documentation, the LINE event does not pass the offset but only the line number:
https://docs.python.org/3.13/library/sys.monitoring.html#callback-function-arguments
It's unclear whether the
PyMonitoring_FireLineEvent()function should be passed an offset then, but it's probably ok for consistency with the otherPyMonitoring_Fire*functions.