Skip to content

gh-118692: Avoid creating unnecessary StopIteration instances for monitoring - #119216

Merged
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:monitoring_stopIteration
May 21, 2024
Merged

gh-118692: Avoid creating unnecessary StopIteration instances for monitoring#119216
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:monitoring_stopIteration

Conversation

@iritkatriel

@iritkatrieliritkatriel commented May 20, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@iritkatriel
iritkatriel requested a review from scoderMay 20, 2024 14:55
@bedevere-appbedevere-appBot mentioned this pull request May 20, 2024
Closed
@iritkatriel
iritkatriel removed the request for review from gvanrossumMay 20, 2024 14:55
markshannon
markshannon requested changes May 20, 2024
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible NULL dereference needs fixing. Looks good, otherwise.

Comment threadPython/instrumentation.c
@bedevere-app

bedevere-appBot commented May 20, 2024

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@iritkatriel

iritkatriel commented May 21, 2024

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again.

@bedevere-app

bedevere-appBot commented May 21, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

@bedevere-app
bedevere-appBot requested a review from markshannonMay 21, 2024 17:51
@iritkatriel
iritkatriel enabled auto-merge (squash) May 21, 2024 20:02
@iritkatriel
iritkatriel merged commit 6e9863d into python:mainMay 21, 2024
@scoder

scoder commented May 24, 2024

Copy link
Copy Markdown
Contributor

This needs backporting to 3.13.

@scoderscoder added the needs backport to 3.13 bugs and security fixes label May 24, 2024
@miss-islington-app

miss-islington-appBot commented May 24, 2024

Copy link
Copy Markdown

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2024
@iritkatriel@miss-islington
pythongh-118692: Avoid creating unnecessary StopIteration instances f…
06943e2
…or monitoring (pythonGH-119216)
(cherry picked from commit 6e9863d)
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented May 24, 2024

Copy link
Copy Markdown

GH-119497 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 24, 2024
@scoderscoder added the 3.13 bugs and security fixes label May 24, 2024
iritkatriel added a commit that referenced this pull request May 24, 2024
@miss-islington@iritkatriel
[3.13]gh-118692: Avoid creating unnecessary StopIteration instances …
c864efb
…for monitoring (GH-119216) (#119497)
* gh-118692: Avoid creating unnecessary StopIteration instances for monitoring (GH-119216)
(cherry picked from commit 6e9863d)
---------
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@JelleZijlstraJelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@iritkatriel@estyxx
pythongh-118692: Avoid creating unnecessary StopIteration instances f…
4eb906e
…or monitoring (python#119216)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon approved these changes
@scoderscoderAwaiting requested review from scoder

Assignees

No one assigned

Labels

3.13bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid creating a StopIteration instance for monitoring

3 participants

@iritkatriel@scoder@markshannon